Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 61673002: Remove HTMLBaseFontElement IDL and implementation (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
blink-reviews, dglazkov+blink, arv+blink, adamk+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove HTMLBaseFontElement IDL and implementation This is dead code because it doesn't appear in the GYP files and HTMLTagNames.in already says "basefont interfaceName=HTMLElement". BUG=315480 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -108 lines) Patch
D Source/core/html/HTMLBaseFontElement.h View 1 chunk +0 lines, -40 lines 0 comments Download
D Source/core/html/HTMLBaseFontElement.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
D Source/core/html/HTMLBaseFontElement.idl View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
7 years, 1 month ago (2013-11-06 08:52:59 UTC) #1
eseidel
lgtm
7 years, 1 month ago (2013-11-06 09:06:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/61673002/1
7 years, 1 month ago (2013-11-06 09:06:55 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=15846
7 years, 1 month ago (2013-11-06 10:26:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/61673002/1
7 years, 1 month ago (2013-11-06 10:35:05 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 11:05:54 UTC) #6
Message was sent while issue was closed.
Change committed as 161449

Powered by Google App Engine
This is Rietveld 408576698