Issue 616703004: Merge 183104 "Force ComplexPath if any part of the node requires it"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 616703004: Merge 183104 "Force ComplexPath if any part of the node requires it" (Closed)

Created:
6 years, 2 months ago by eae

Modified:
6 years, 2 months ago

Reviewers:
eae

CC:
blink-reviews, jamesr, pdr+graphicswatchlist_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, jbroman, mkwst+moarreviews_chromium.org, danakj, zoltan1, Rik, jchaffraix+rendering, blink-reviews-rendering, Stephen Chennney, rune+blink, krit, rwlbuis

Base URL:
svn://svn.chromium.org/blink/branches/chromium/2171/

Project:
blink

Visibility:
Public.

More Reviews

Description

Merge 183104 "Force ComplexPath if any part of the node requires it" > Force ComplexPath if any part of the node requires it > > Change our font measurement/rendering logic to force the ComplexPath for > the entire RenderText if any part of it requires it. This ensures > consistency between preferred width and line break calculations. > Also change FontCacheSkiaWin to use the subpixel settings from the > primary font in case of character based fallback. > > TEST=fast/text/international/complex-text-with-default-font-spaces.html > BUG=412758 > R=leviw@chromium.org > > Review URL: https://codereview.chromium.org/622653002 TBR=eae@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183160

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -1 line)			Patch
M	LayoutTests/NeverFixTests	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/TestExpectations	View	2 chunks	+26 lines, -1 line	0 comments	Download
A +	LayoutTests/fast/text/international/complex-text-with-default-font-spaces.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/text/international/complex-text-with-default-font-spaces-expected.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/rendering/RenderText.cpp	View	2 chunks	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/line/BreakingContextInlineHeaders.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/platform/fonts/Font.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/platform/fonts/win/FontCacheSkiaWin.cpp	View	2 chunks	+12 lines, -1 line	0 comments	Download
M	Source/platform/text/TextRun.h	View	6 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r183160.

Expand Messages | Collapse Messages