Issue 616703003: Should remove |struct HitRegionOptionsInternal|.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 616703003: Should remove |struct HitRegionOptionsInternal|. (Closed)

Created:
6 years, 2 months ago by zino

Modified:
6 years, 2 months ago

Reviewers:
Justin Novosad

CC:
blink-reviews, aandrey+blink_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Should remove struct HitRegionOptionsInternal. We don't need the struct because we already have IDL dictionary support. BUG=none TEST=existing tests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183005

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -43 lines)			Patch
M	Source/core/html/canvas/CanvasRenderingContext2D.h	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/core/html/canvas/CanvasRenderingContext2D.cpp	View		3 chunks	+4 lines, -20 lines	0 comments	Download
M	Source/core/html/canvas/HitRegion.h	View		3 chunks	+4 lines, -15 lines	0 comments	Download
M	Source/core/html/canvas/HitRegion.cpp	View		1 chunk	+9 lines, -6 lines	0 comments	Download

Total messages: 6 (2 generated)

Justin Novosad

On 2014/09/30 05:44:14, zino wrote: > Simple clean-up, PTAL. > Thank you. Thanks for this. ...

6 years, 2 months ago (2014-09-30 14:29:02 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616703003/20001

6 years, 2 months ago (2014-09-30 23:52:52 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-09-30 23:57:12 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 183005