Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 616703002: Disable ShelfView Touch Feedback tests (Closed)

Created:
6 years, 2 months ago by jonross
Modified:
6 years, 2 months ago
Reviewers:
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable ShelfView Touch Feedback tests ShelfViewTest.AppListButtonTouchFeedback and ShelfViewTest.AppListButtonTouchFeedbackCancellation are both failing on Valgrind after the refactor of the feedback switch. The tests does not have a memory failure, the test cases are failing now. Disabling the tests until they can be fixed. This is a follow up to: https://codereview.chromium.org/580903003/ TBR=skuhne@chromium.org BUG=398398 Committed: https://crrev.com/e385a899e76dc817d02cbe5ee62d60197fc88034 Cr-Commit-Position: refs/heads/master@{#297321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ash/shelf/shelf_view_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616703002/1
6 years, 2 months ago (2014-09-29 23:53:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as f580c221e61114e2367d1fd14fc2e2ae6aadbc27
6 years, 2 months ago (2014-09-30 00:56:46 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 00:57:34 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e385a899e76dc817d02cbe5ee62d60197fc88034
Cr-Commit-Position: refs/heads/master@{#297321}

Powered by Google App Engine
This is Rietveld 408576698