[Ozone-Evdev] Propagate touchscreen device information to DeviceDataManager

ui/events/ozone/evdev/event_converter_evdev.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/ozone/evdev/event_converter_evdev.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
+#include "ui/events/ozone/evdev/event_device_info.h"
 
 namespace ui {
 
-EventConverterEvdev::EventConverterEvdev(int fd, const base::FilePath& path)
-    : fd_(fd), path_(path) {
+EventConverterEvdev::EventConverterEvdev(
+    int fd,
+    const base::FilePath& path,
+    scoped_ptr<EventDeviceInfo> device_info)

[spang, 2014/09/29 23:54:35]

Do we actually need to store EventDeviceInfo? You really only need to keep the
size..

[dnicoara, 2014/09/30 18:23:27]

Size + properties to figure out what type of device it is. This seems like the
cleanest way.

[spang, 2014/09/30 18:59:23]

Just add two functions to EventConvertEvdev:
  HasTouchscreen()
  GetTouchscreenSize()

Let's please use the ABS_MT ioctl info in one place only.

[dnicoara, 2014/09/30 19:09:31]

The getters never call the ioctls. One would have to run
EventDeviceInfo::Initialize to perform the ioctls. Sorry, am I missing
something?

+    : fd_(fd), path_(path), device_info_(device_info.Pass()) {
 }
 
 EventConverterEvdev::~EventConverterEvdev() {
   Stop();
 }
 
 void EventConverterEvdev::Start() {
   base::MessageLoopForUI::current()->WatchFileDescriptor(
       fd_, true, base::MessagePumpLibevent::WATCH_READ, &controller_, this);
 }
 
 void EventConverterEvdev::Stop() {
   controller_.StopWatchingFileDescriptor();
 }
 
 void EventConverterEvdev::OnFileCanWriteWithoutBlocking(int fd) {
   NOTREACHED();
 }
 
 }  // namespace ui