Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 616603006: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/editing (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Mike West, dcheng
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/editing This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183379

Patch Set 1 #

Patch Set 2 : Rebased the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -171 lines) Patch
M Source/core/editing/AppendNodeCommand.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/ApplyBlockElementCommand.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/ApplyStyleCommand.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/BreakBlockquoteCommand.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/Caret.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/CompositeEditCommand.h View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/CreateLinkCommand.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/DOMSelection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/DeleteFromTextNodeCommand.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/DeleteSelectionCommand.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/editing/EditCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 3 chunks +12 lines, -12 lines 0 comments Download
M Source/core/editing/Editor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FormatBlockCommand.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/FrameSelection.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/FrameSelectionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/IndentOutdentCommand.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/InputMethodController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InputMethodControllerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertIntoTextNodeCommand.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/InsertLineBreakCommand.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/InsertListCommand.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/InsertNodeBeforeCommand.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/InsertTextCommand.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/MergeIdenticalElementsCommand.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/MoveSelectionCommand.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/RemoveCSSPropertyCommand.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/RemoveFormatCommand.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/RemoveNodeCommand.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/RemoveNodePreservingChildrenCommand.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/ReplaceNodeWithSpanCommand.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SetNodeAttributeCommand.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/SimplifyMarkupCommand.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/SpellCheckRequester.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/SpellChecker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SplitElementCommand.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/editing/SplitTextNodeCommand.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/editing/SplitTextNodeContainingElementCommand.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/SurroundingTextTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TextIteratorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TypingCommand.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/editing/UndoStack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/UnlinkCommand.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/VisiblePosition.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisibleSelectionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/WrapContentsInDummySpanCommand.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/editing/markup.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 12:19:22 UTC) #2
Mike West
rs lgtm.
6 years, 2 months ago (2014-10-07 13:33:45 UTC) #4
MRV
On 2014/10/07 13:33:45, Mike West wrote: > rs lgtm. Thanks Mr. Mike
6 years, 2 months ago (2014-10-07 13:35:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616603006/1
6 years, 2 months ago (2014-10-07 13:35:51 UTC) #7
commit-bot: I haz the power
Failed to apply patch for Source/core/animation/Animation.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 2 months ago (2014-10-07 15:28:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616603006/20001
6 years, 2 months ago (2014-10-08 02:58:13 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 04:38:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183379

Powered by Google App Engine
This is Rietveld 408576698