Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2487)

Unified Diff: cc/resources/tile_manager_perftest.cc

Issue 616543004: cc: Use visible_rect_for_tile_priority_ where approriate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: UpdateTiles Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/tile_manager_perftest.cc
diff --git a/cc/resources/tile_manager_perftest.cc b/cc/resources/tile_manager_perftest.cc
index e83596c9ba3d8bc82db9f6e3224f28915f2ab916..3431ec8bb259d16634a58141fd4420bbc7e25a40 100644
--- a/cc/resources/tile_manager_perftest.cc
+++ b/cc/resources/tile_manager_perftest.cc
@@ -188,8 +188,11 @@ class TileManagerPerfTest : public testing::Test {
int priority_count = 0;
std::vector<LayerImpl*> layers = CreateLayers(layer_count, 10);
- for (unsigned i = 0; i < layers.size(); ++i)
- layers[i]->UpdateTiles(Occlusion());
+ bool draw_properties_valid_for_tile_priority = true;
+ for (unsigned i = 0; i < layers.size(); ++i) {
+ layers[i]->UpdateTiles(Occlusion(),
+ draw_properties_valid_for_tile_priority);
+ }
timer_.Reset();
do {
@@ -215,8 +218,11 @@ class TileManagerPerfTest : public testing::Test {
NEW_CONTENT_TAKES_PRIORITY};
std::vector<LayerImpl*> layers = CreateLayers(layer_count, 100);
- for (unsigned i = 0; i < layers.size(); ++i)
- layers[i]->UpdateTiles(Occlusion());
+ bool draw_properties_valid_for_tile_priority = true;
+ for (unsigned i = 0; i < layers.size(); ++i) {
+ layers[i]->UpdateTiles(Occlusion(),
+ draw_properties_valid_for_tile_priority);
+ }
int priority_count = 0;
timer_.Reset();
@@ -250,10 +256,11 @@ class TileManagerPerfTest : public testing::Test {
int priority_count = 0;
std::vector<LayerImpl*> layers = CreateLayers(layer_count, 10);
+ bool draw_properties_valid_for_tile_priority = true;
for (unsigned i = 0; i < layers.size(); ++i) {
FakePictureLayerImpl* layer =
static_cast<FakePictureLayerImpl*>(layers[i]);
- layer->UpdateTiles(Occlusion());
+ layer->UpdateTiles(Occlusion(), draw_properties_valid_for_tile_priority);
for (size_t j = 0; j < layer->GetTilings()->num_tilings(); ++j) {
tile_manager()->InitializeTilesWithResourcesForTesting(
layer->GetTilings()->tiling_at(j)->AllTilesForTesting());
@@ -285,10 +292,11 @@ class TileManagerPerfTest : public testing::Test {
int priority_count = 0;
std::vector<LayerImpl*> layers = CreateLayers(layer_count, tile_count);
+ bool draw_properties_valid_for_tile_priority = true;
for (unsigned i = 0; i < layers.size(); ++i) {
FakePictureLayerImpl* layer =
static_cast<FakePictureLayerImpl*>(layers[i]);
- layer->UpdateTiles(Occlusion());
+ layer->UpdateTiles(Occlusion(), draw_properties_valid_for_tile_priority);
for (size_t j = 0; j < layer->GetTilings()->num_tilings(); ++j) {
tile_manager()->InitializeTilesWithResourcesForTesting(
layer->GetTilings()->tiling_at(j)->AllTilesForTesting());
@@ -394,11 +402,14 @@ class TileManagerPerfTest : public testing::Test {
std::vector<LayerImpl*> layers =
CreateLayers(layer_count, approximate_tile_count_per_layer);
timer_.Reset();
+ bool draw_properties_valid_for_tile_priority = true;
do {
BeginFrameArgs args = CreateBeginFrameArgsForTesting();
host_impl_.UpdateCurrentBeginFrameArgs(args);
- for (unsigned i = 0; i < layers.size(); ++i)
- layers[i]->UpdateTiles(Occlusion());
+ for (unsigned i = 0; i < layers.size(); ++i) {
+ layers[i]->UpdateTiles(Occlusion(),
+ draw_properties_valid_for_tile_priority);
+ }
GlobalStateThatImpactsTilePriority global_state(GlobalStateForTest());
tile_manager()->ManageTiles(global_state);

Powered by Google App Engine
This is Rietveld 408576698