Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 616513004: Convert the remaining MOJO_OVERRIDE -> override, and get rid of MOJO_OVERRIDE. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Convert the remaining MOJO_OVERRIDE -> override, and get rid of MOJO_OVERRIDE. (As a drive-by, also convert some OVERRIDE -> override.) R=tim@chromium.org TBR=scherkus@chromium.org Committed: https://crrev.com/5323fc4ff170a26ae096c0ff1d954d4b74547a55 Cr-Commit-Position: refs/heads/master@{#297435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -24 lines) Patch
M media/mojo/services/mojo_renderer_impl.h View 1 chunk +13 lines, -13 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.h View 1 chunk +5 lines, -5 lines 0 comments Download
M mojo/public/cpp/system/macros.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
viettrungluu
6 years, 2 months ago (2014-09-30 03:46:09 UTC) #1
tim (not reviewing)
LGTM
6 years, 2 months ago (2014-09-30 04:09:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616513004/1
6 years, 2 months ago (2014-09-30 04:12:31 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14325)
6 years, 2 months ago (2014-09-30 04:20:15 UTC) #6
viettrungluu
scherkus -> OWNERS TBR
6 years, 2 months ago (2014-09-30 16:29:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616513004/1
6 years, 2 months ago (2014-09-30 16:30:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 07c8172b9e132dd390c9de0082c3eddff7685baa
6 years, 2 months ago (2014-09-30 16:35:27 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 16:36:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5323fc4ff170a26ae096c0ff1d954d4b74547a55
Cr-Commit-Position: refs/heads/master@{#297435}

Powered by Google App Engine
This is Rietveld 408576698