Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 616513003: Disable groupcloned.com_test_list-images page from key_mobile_sites (Closed)

Created:
6 years, 2 months ago by Yufeng Shen (Slow to review)
Modified:
6 years, 2 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable groupcloned.com_test_list-images page from key_mobile_sites The mean_input_event_latency result of groupcloned.com_test_list-images is not correct and is adding too much noise to the metric over the page set. We want to exclude its mean_input_event_latency from the test result which is pending the telemetry feature of page result filter. So for now, lets disable the this page. BUG=409086 Committed: https://crrev.com/90764ffc24ef395cf7d12898cb554f1d548339b3 Cr-Commit-Position: refs/heads/master@{#297310}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/perf/page_sets/key_mobile_sites.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Yufeng Shen (Slow to review)
6 years, 2 months ago (2014-09-29 22:10:25 UTC) #2
nednguyen
https://codereview.chromium.org/616513003/diff/1/tools/perf/page_sets/key_mobile_sites.py File tools/perf/page_sets/key_mobile_sites.py (right): https://codereview.chromium.org/616513003/diff/1/tools/perf/page_sets/key_mobile_sites.py#newcode368 tools/perf/page_sets/key_mobile_sites.py:368: 'crbug.com/409086') I don't like this disabled feature. Can you ...
6 years, 2 months ago (2014-09-29 22:41:21 UTC) #3
Yufeng Shen (Slow to review)
https://codereview.chromium.org/616513003/diff/1/tools/perf/page_sets/key_mobile_sites.py File tools/perf/page_sets/key_mobile_sites.py (right): https://codereview.chromium.org/616513003/diff/1/tools/perf/page_sets/key_mobile_sites.py#newcode368 tools/perf/page_sets/key_mobile_sites.py:368: 'crbug.com/409086') On 2014/09/29 22:41:21, nednguyen wrote: > I don't ...
6 years, 2 months ago (2014-09-29 22:46:50 UTC) #4
Yufeng Shen (Slow to review)
https://codereview.chromium.org/616513003/diff/1/tools/perf/page_sets/key_mobile_sites.py File tools/perf/page_sets/key_mobile_sites.py (right): https://codereview.chromium.org/616513003/diff/1/tools/perf/page_sets/key_mobile_sites.py#newcode368 tools/perf/page_sets/key_mobile_sites.py:368: 'crbug.com/409086') On 2014/09/29 22:41:21, nednguyen wrote: > I don't ...
6 years, 2 months ago (2014-09-29 22:46:51 UTC) #5
nednguyen
lgtm
6 years, 2 months ago (2014-09-29 22:55:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616513003/40001
6 years, 2 months ago (2014-09-29 22:57:07 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as a16d9e56dd51b87545c3a1fb29fc645fa0e4f99c
6 years, 2 months ago (2014-09-30 00:01:24 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 00:02:24 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/90764ffc24ef395cf7d12898cb554f1d548339b3
Cr-Commit-Position: refs/heads/master@{#297310}

Powered by Google App Engine
This is Rietveld 408576698