Source/platform/heap/HeapTest.cpp - Issue 616483002: Oilpan: Replace the positive heap-contains cache with a binary search tree of memory regions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/HeapTest.cpp

Issue 616483002: Oilpan: Replace the positive heap-contains cache with a binary search tree of memory regions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: lookup assert Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/heap/HeapTest.cpp

diff --git a/Source/platform/heap/HeapTest.cpp b/Source/platform/heap/HeapTest.cpp

index e4a8cb8e7470466a342aed7437fe954f6d1d966b..9534342188a31cb0cf581e83e3d767e4c2158da1 100644

--- a/Source/platform/heap/HeapTest.cpp

+++ b/Source/platform/heap/HeapTest.cpp

@@ -3321,7 +3321,7 @@ TEST(HeapTest, CheckAndMarkPointer)

{

TestGCScope scope(ThreadState::HeapPointersOnStack);

EXPECT_TRUE(scope.allThreadsParked()); // Fail the test if we could not park all threads.

- Heap::makeConsistentForSweeping();

+ Heap::prepareForGC();

for (size_t i = 0; i < objectAddresses.size(); i++) {

EXPECT_TRUE(Heap::checkAndMarkPointer(&visitor, objectAddresses[i]));

EXPECT_TRUE(Heap::checkAndMarkPointer(&visitor, endAddresses[i]));

« no previous file with comments | « Source/platform/heap/Heap.cpp ('k') | Source/platform/heap/ThreadState.h » ('j') | no next file with comments »