Proxy private UMA pepper interface for out-of-process and NaCl plugins.

chrome/renderer/pepper/pepper_uma_host.h

Index: chrome/renderer/pepper/pepper_uma_host.h
diff --git a/chrome/renderer/pepper/pepper_uma_host.h b/chrome/renderer/pepper/pepper_uma_host.h
new file mode 100644
index 0000000000000000000000000000000000000000..6f8986a1679dfd36f1ada3cb13563a7c48a27583
--- /dev/null
+++ b/chrome/renderer/pepper/pepper_uma_host.h
@@ -0,0 +1,75 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.

[yzshen1, 2014/01/08 00:26:24]

nit: Please consider changing to 2014 (here and other new files)

[elijahtaylor1, 2014/01/08 23:59:41]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_RENDERER_PEPPER_PEPPER_UMA_HOST_H_
+#define CHROME_RENDERER_PEPPER_PEPPER_UMA_HOST_H_
+
+#include <set>
+#include <string>
+
+#include "ppapi/c/pp_instance.h"
+#include "ppapi/c/pp_resource.h"
+#include "ppapi/host/resource_host.h"
+#include "url/gurl.h"
+
+namespace content {
+class RendererPpapiHost;
+}
+
+namespace ppapi {
+namespace host {
+struct HostMessageContext;
+}  // namespace host
+}  // namespace ppapi
+
+class PepperUMAHost : public ppapi::host::ResourceHost {
+ public:
+  PepperUMAHost(content::RendererPpapiHost* host,
+      PP_Instance instance,

[yzshen1, 2014/01/08 00:26:24]

nit: Please either align with content::... on the previous line or move the
first param to a separate line.

[elijahtaylor1, 2014/01/08 23:59:41]

Done.

+      PP_Resource resource);
+
+  // ppapi::host::ResourceMessageHandler implementation.
+  virtual int32_t OnResourceMessageReceived(
+      const IPC::Message& msg,
+      ppapi::host::HostMessageContext* context) OVERRIDE;
+
+  virtual ~PepperUMAHost();

[bbudge, 2014/01/08 19:01:49]

It's more conventional for this to follow the ctor. These should also be grouped
together in the .cc file.

[elijahtaylor1, 2014/01/08 23:59:41]

Done.

+
+ private:
+  bool IsHistogramAllowed(const std::string& histogram);
+
+  int32_t OnHistogramCustomTimes(
+      ppapi::host::HostMessageContext* context,
+      const std::string& name,
+      int64_t sample,
+      int64_t min,
+      int64_t max,
+      uint32_t bucket_count);
+
+  int32_t OnHistogramCustomCounts(
+      ppapi::host::HostMessageContext* context,
+      const std::string& name,
+      int32_t sample,
+      int32_t min,
+      int32_t max,
+      uint32_t bucket_count);
+
+  int32_t OnHistogramEnumeration(
+      ppapi::host::HostMessageContext* context,
+      const std::string& name,
+      int32_t sample,
+      int32_t boundary_value);
+
+  const GURL document_url_;
+  bool is_plugin_in_process_;
+
+  // Set of origins that can use UMA private APIs from NaCl.
+  std::set<std::string> allowed_origins_;
+  // Set of histograms that can be used from this interface.
+  std::set<std::string> allowed_histograms_;
+
+  DISALLOW_COPY_AND_ASSIGN(PepperUMAHost);
+};
+
+#endif  // CHROME_RENDERER_PEPPER_PEPPER_UMA_HOST_H_