Proxy private UMA pepper interface for out-of-process and NaCl plugins.

chrome/renderer/pepper/pepper_uma_renderer_host.h

Index: chrome/renderer/pepper/pepper_uma_renderer_host.h
diff --git a/chrome/renderer/pepper/pepper_uma_renderer_host.h b/chrome/renderer/pepper/pepper_uma_renderer_host.h
new file mode 100644
index 0000000000000000000000000000000000000000..2335816568ecc7c27d3df41670e88390dc3132cb
--- /dev/null
+++ b/chrome/renderer/pepper/pepper_uma_renderer_host.h
@@ -0,0 +1,77 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_RENDERER_PEPPER_PEPPER_UMA_RENDERER_HOST_H_
+#define CHROME_RENDERER_PEPPER_PEPPER_UMA_RENDERER_HOST_H_
+
+#include <set>
+#include <string>
+
+#include "base/files/file_path.h"

[yzshen1, 2013/12/04 19:32:51]

no need to have this one, right?

[elijahtaylor1, 2013/12/21 02:26:21]

Done.

+#include "ppapi/c/pp_instance.h"
+#include "ppapi/c/pp_resource.h"
+#include "ppapi/host/resource_host.h"
+#include "ppapi/host/resource_message_filter.h"

[yzshen1, 2013/12/04 19:32:51]

we don't need this one, right?

[elijahtaylor1, 2013/12/21 02:26:21]

Done.

+#include "url/gurl.h"
+
+namespace content {
+class RendererPpapiHost;
+}
+
+namespace ppapi {
+namespace host {
+struct HostMessageContext;
+}  // namespace host
+}  // namespace ppapi
+
+class PepperUMARendererHost : public ppapi::host::ResourceHost {
+ public:
+  PepperUMARendererHost(content::RendererPpapiHost* host, PP_Instance instance,

[yzshen1, 2013/12/04 19:32:51]

one parameter on each line, please (this is required for declaration and
definition, but not invocation)

[elijahtaylor1, 2013/12/21 02:26:21]

Done.

+      PP_Resource resource);
+

[yzshen1, 2013/12/04 19:32:51]

redundant line.

[elijahtaylor1, 2013/12/21 02:26:21]

Done.

+
+  // ppapi::host::ResourceMessageHandler implementation.
+  virtual int32_t OnResourceMessageReceived(
+      const IPC::Message& msg,
+      ppapi::host::HostMessageContext* context) OVERRIDE;
+
+ private:
+  virtual ~PepperUMARendererHost();

[yzshen1, 2013/12/04 19:32:51]

It seems we don't have to make it a private method. Or you would like to make
sure we always delete the object with a pointer of ResourceHost?

[elijahtaylor1, 2013/12/21 02:26:21]

Done.

+
+  bool IsHistogramAllowed(const std::string& histogram);
+
+  int32_t OnHistogramCustomTimes(
+      ppapi::host::HostMessageContext* context,
+      const std::string& name,
+      int64_t sample,
+      int64_t min,
+      int64_t max,
+      uint32_t bucket_count);
+
+  int32_t OnHistogramCustomCounts(
+      ppapi::host::HostMessageContext* context,
+      const std::string& name,
+      int32_t sample,
+      int32_t min,
+      int32_t max,
+      uint32_t bucket_count);
+
+  int32_t OnHistogramEnumeration(
+      ppapi::host::HostMessageContext* context,
+      const std::string& name,
+      int32_t sample,
+      int32_t boundary_value);
+
+  const GURL document_url_;
+  bool is_plugin_in_process_;
+
+  // Set of origins that can use UMA private APIs from NaCl.
+  std::set<std::string> allowed_origins_;
+  // Set of histograms that can be used from this interface.
+  std::set<std::string> allowed_histograms_;
+
+  DISALLOW_COPY_AND_ASSIGN(PepperUMARendererHost);
+};
+
+#endif  // CHROME_RENDERER_PEPPER_PEPPER_UMA_RENDERER_HOST_H_