Proxy private UMA pepper interface for out-of-process and NaCl plugins.

ppapi/proxy/uma_private_resource.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ppapi/proxy/uma_private_resource.h"
+
+#include "base/bind.h"
+#include "ppapi/proxy/ppapi_messages.h"
+#include "ppapi/proxy/resource_message_params.h"
+#include "ppapi/shared_impl/host_resource.h"

[yzshen1, 2013/12/04 19:32:51]

this is not necessary, right?

[elijahtaylor1, 2013/12/21 02:26:21]

Done.

+#include "ppapi/shared_impl/var.h"
+#include "ppapi/thunk/enter.h"

[yzshen1, 2013/12/04 19:32:51]

ditto

[elijahtaylor1, 2013/12/21 02:26:21]

Done.

+
+namespace {
+
+std::string StringFromPPVar(PP_Var var) {

[yzshen1, 2013/12/04 19:32:51]

const &, please.

[elijahtaylor1, 2013/12/21 02:26:21]

Done.

+  scoped_refptr<ppapi::StringVar> name_stringvar =
+      ppapi::StringVar::FromPPVar(var);

[yzshen1, 2013/12/04 19:32:51]

Please check NULL before using it.

[elijahtaylor1, 2013/12/21 02:26:21]

Done.

+  return name_stringvar->value();
+}
+
+}
+
+namespace ppapi {
+namespace proxy {
+
+UMAPrivateResource::UMAPrivateResource(
+    Connection connection, PP_Instance instance)
+    : PluginResource(connection, instance) {
+  SendCreate(RENDERER, PpapiHostMsg_UMA_Create());
+}
+
+UMAPrivateResource::~UMAPrivateResource() {
+}
+
+thunk::PPB_UMA_Singleton_API* UMAPrivateResource::AsPPB_UMA_Singleton_API() {
+  return this;
+}
+
+void UMAPrivateResource::HistogramCustomTimes(
+    PP_Instance instance,
+    struct PP_Var name,
+    int64_t sample,
+    int64_t min,
+    int64_t max,
+    uint32_t bucket_count) {
+

[yzshen1, 2013/12/04 19:32:51]

no need to have this line (all methods below)

[elijahtaylor1, 2013/12/21 02:26:21]

Done.

+  if (name.type != PP_VARTYPE_STRING)
+    return;
+
+  Post(RENDERER, PpapiHostMsg_UMA_HistogramCustomTimes(StringFromPPVar(name),
+                                                      sample,
+                                                      min,

[yzshen1, 2013/12/04 19:32:51]

wrong indent (all methods below)

[elijahtaylor1, 2013/12/21 02:26:21]

Done.

+                                                      max,
+                                                      bucket_count));
+}
+
+void UMAPrivateResource::HistogramCustomCounts(
+    PP_Instance instance,
+    struct PP_Var name,
+    int32_t sample,
+    int32_t min,
+    int32_t max,
+    uint32_t bucket_count) {
+
+  if (name.type != PP_VARTYPE_STRING)
+    return;
+
+  Post(RENDERER, PpapiHostMsg_UMA_HistogramCustomCounts(StringFromPPVar(name),
+                                                       sample,
+                                                       min,
+                                                       max,
+                                                       bucket_count));
+}
+
+void UMAPrivateResource::HistogramEnumeration(
+    PP_Instance instance,
+    struct PP_Var name,
+    int32_t sample,
+    int32_t boundary_value) {
+
+  if (name.type != PP_VARTYPE_STRING)
+    return;
+
+  Post(RENDERER, PpapiHostMsg_UMA_HistogramEnumeration(StringFromPPVar(name),
+                                                      sample,
+                                                      boundary_value));
+}
+
+}  // namespace proxy
+}  // namespace ppapi
+