Proxy private UMA pepper interface for out-of-process and NaCl plugins.

ppapi/cpp/private/uma_private.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PPAPI_CPP_PRIVATE_UMA_PRIVATE_H_
+#define PPAPI_CPP_PRIVATE_UMA_PRIVATE_H_
+
+#include <string>
+
+#include "ppapi/c/pp_instance.h"
+#include "ppapi/cpp/instance_handle.h"
+
+namespace pp {
+
+class UMAPrivate {
+ public:
+  UMAPrivate();
+  explicit UMAPrivate(const InstanceHandle& instance);
+  virtual ~UMAPrivate();

[yzshen1, 2013/12/04 19:32:51]

it doesn't require a virtual constructor, right?

[elijahtaylor1, 2013/12/21 02:26:21]

Done.

+
+  int32_t HistogramCustomTimes(const std::string& name,

[yzshen1, 2013/12/04 19:32:51]

It seems there is no need to return int32_t, now that the C interface returns
void.

[elijahtaylor1, 2013/12/21 02:26:21]

This was mostly to be able to return PP_ERROR_NOINTERFACE.  Do you think I
should just change to return; ?

[yzshen1, 2014/01/08 00:26:24]

Maybe we can have a static bool IsAvailable() method, and just return void for
all the other methods.
We already have some classes that have an IsAvailable() method.

What do you think?

On 2013/12/21 02:26:21, elijahtaylor1 wrote:

[elijahtaylor1, 2014/01/08 23:59:41]

Done.

+                               int64_t sample,
+                               int64_t min,
+                               int64_t max,
+                               uint32_t bucket_count) const;

[yzshen1, 2013/12/04 19:32:51]

It seems a little bit weird to use const for these methods, semantically they do
change internal state.

[bbudge, 2013/12/04 21:08:30]

These are really static methods. Why not define them that way, taking an
InstanceHandle as the first parameter? See:
https://code.google.com/p/chromium/codesearch#chromium/src/ppapi/cpp/dev/font...
https://code.google.com/p/chromium/codesearch#chromium/src/ppapi/cpp/network_...

[elijahtaylor1, 2013/12/21 02:26:21]

I can do that, but I'm wondering if you would accept some pushback on this.  The
main reason I made this C++ class was to hold the instance to make it easier for
code using this interface.  If each method required an InstanceHandle, they
might as well just use the C interface and pass a PP_Instance to every method.

[elijahtaylor1, 2013/12/21 02:26:21]

They change internal state of chrome, but not of the class.  I can remove the
const if you want.

[yzshen1, 2014/01/08 00:26:24]

I understand your point. I just think that would be more consistent with other
classes.

On 2013/12/21 02:26:21, elijahtaylor1 wrote:

[elijahtaylor1, 2014/01/08 23:59:41]

Done.

+
+  int32_t HistogramCustomCounts(const std::string& name,
+                                int32_t sample,
+                                int32_t min,
+                                int32_t max,
+                                uint32_t bucket_count) const;
+
+  int32_t HistogramEnumeration(const std::string& name,
+                               int32_t sample,
+                               int32_t boundary_value) const;
+
+ private:
+  PP_Instance instance_;
+};
+
+}  // namespace pp
+
+#endif  // PPAPI_CPP_PRIVATE_UMA_PRIVATE_H_