Remove the intent to turn on Wextra for gcc (except MacOS)

build/common.gypi

Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 01078b9384fc21099918f1ac35a977ed4c167e81..00d1377e3e9cc92df7b3f3e782d6ca8ce4868173 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2840,12 +2840,6 @@
           '-fno-exceptions',
           '-fno-strict-aliasing',  # See http://crbug.com/32204
           '-Wall',
-          # TODO(evan): turn this back on once all the builds work.
-          # '-Wextra',
-          # Don't warn about unused function params.  We use those everywhere.
-          '-Wno-unused-parameter',
-          # Don't warn about the "struct foo f = {0};" initialization pattern.
-          '-Wno-missing-field-initializers',

[Nico, 2013/11/10 03:41:08]

Are -Wno-unused-parameter and -Wno-missing-field-initializers not needed? Mac
below still has it for example. Is this turned off elsewhere? Is it not needed
if -Wextra isn't on?

[lgombos, 2013/11/10 04:16:28]

The scope of this section is 'os_posix==1 and OS!="mac" and OS!="ios"'. Mac has
a section with -Wextra and -Wno-unused-parameter  turned on.

 

[lgombos, 2014/07/04 19:06:46]

It is the latter - it is not needed if -Wextra isn't on.

           # Don't export any symbols (for example, to plugins we dlopen()).
           # Note: this is *required* to make some plugins work.
           '-fvisibility=hidden',