Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: chrome/browser/extensions/api/image_writer_private/test_utils.cc

Issue 61643015: Adds imageWriterPrivate support for Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup and now working on Windows with minimal changes. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/image_writer_private/test_utils.cc
diff --git a/chrome/browser/extensions/api/image_writer_private/test_utils.cc b/chrome/browser/extensions/api/image_writer_private/test_utils.cc
index 999898bd9029da0a3c01d01735977336fe93bf97..7d6fde21bf77ebc06889a79ff6f8881a531e1911 100644
--- a/chrome/browser/extensions/api/image_writer_private/test_utils.cc
+++ b/chrome/browser/extensions/api/image_writer_private/test_utils.cc
@@ -51,14 +51,34 @@ class ImageWriterFakeImageBurnerClient
} // namespace
#endif
+QuittingMockManager::QuittingMockManager(const base::Closure& quit_closure)
+ : quit_closure_(quit_closure) {}
+
+void QuittingMockManager::OnComplete(const ExtensionId& extension_id) {
+ MockOperationManager::OnComplete(extension_id);
+ quit_closure_.Run();
+}
+
+void QuittingMockManager::OnError(const ExtensionId& extension_id,
+ image_writer_api::Stage stage,
+ int progress,
+ const std::string& error_message) {
+ MockOperationManager::OnError(extension_id, stage, progress, error_message);
+ quit_closure_.Run();
+}
+
MockOperationManager::MockOperationManager() : OperationManager(NULL) {}
MockOperationManager::~MockOperationManager() {}
-ImageWriterUnitTestBase::ImageWriterUnitTestBase() {}
+ImageWriterUnitTestBase::ImageWriterUnitTestBase()
+ : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {}
ImageWriterUnitTestBase::~ImageWriterUnitTestBase() {}
void ImageWriterUnitTestBase::SetUp() {
testing::Test::SetUp();
+
+ // thread_bundle_.reset(new content::TestBrowserThreadBundle());
+
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
ASSERT_TRUE(base::CreateTemporaryFileInDir(temp_dir_.path(),
@@ -87,27 +107,18 @@ void ImageWriterUnitTestBase::TearDown() {
#endif
}
-bool ImageWriterUnitTestBase::CompareImageAndDevice() {
+bool ImageWriterUnitTestBase::ImageWrittenToDevice(
+ const base::FilePath& image_path,
+ const base::FilePath& device_path) {
scoped_ptr<char[]> image_buffer(new char[kTestFileSize]);
scoped_ptr<char[]> device_buffer(new char[kTestFileSize]);
- while (true) {
- int image_bytes_read = ReadFile(test_image_path_,
- image_buffer.get(),
- kTestFileSize);
- int device_bytes_read = ReadFile(test_device_path_,
- device_buffer.get(),
- kTestFileSize);
-
- if (image_bytes_read != device_bytes_read)
- return false;
+ int image_bytes_read =
+ ReadFile(image_path, image_buffer.get(), kTestFileSize);
+ ReadFile(device_path, device_buffer.get(), kTestFileSize);
- if (image_bytes_read == 0)
- return true;
-
- if (memcmp(image_buffer.get(), device_buffer.get(), image_bytes_read) != 0)
- return false;
- }
+ if (memcmp(image_buffer.get(), device_buffer.get(), image_bytes_read) == 0)
+ return true;
return false;
}

Powered by Google App Engine
This is Rietveld 408576698