chrome/utility/image_writer/error_messages.h - Issue 61643015: Adds imageWriterPrivate support for Windows

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/utility/image_writer/error_messages.h

Issue 61643015: Adds imageWriterPrivate support for Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes comment. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/utility/chrome_content_utility_ipc_whitelist.cc ('K') | « chrome/utility/image_writer/OWNERS ('k') | chrome/utility/image_writer/error_messages.cc » ('j') | chrome/utility/image_writer/image_writer.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.
	Lei Zhang 2014/02/15 00:26:59 nit: it's 2014, same elsewhere. nit: it's 2014, same elsewhere. Drew Haven 2014/02/15 01:23:58 I started this CL in 2013... Done. Show quoted text On 2014/02/15 00:26:59, Lei Zhang wrote: > nit: it's 2014, same elsewhere. I started this CL in 2013... Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_EXTENSIONS_API_IMAGE_WRITER_PRIVATE_ERROR_MESSAGES_H_

	6 #define CHROME_BROWSER_EXTENSIONS_API_IMAGE_WRITER_PRIVATE_ERROR_MESSAGES_H_

	7

	8 namespace chrome {

	9 namespace image_writer {

	10 namespace error {

	11

	12 extern const char kCleanUp[];

	13 extern const char kCloseDevice[];

	14 extern const char kCloseImage[];

	15 extern const char kInvalidDevice[];

	16 extern const char kNoOperationInProgress[];

	17 extern const char kOpenDevice[];

	18 extern const char kOpenImage[];

	19 extern const char kOperationAlreadyInProgress[];

	20 extern const char kReadDevice[];

	21 extern const char kReadImage[];

	22 extern const char kWriteImage[];

	23 extern const char kVerificationFailed[];

	24

	25 } // namespace error

	26 } // namespace image_writer

	27 } // namespace extensions
	Lei Zhang 2014/02/15 00:26:59 nit: this comment is inconsistent with line 8. We nit: this comment is inconsistent with line 8. We decided to not bother with "namespace chrome" BTW, since chrome/ is the top level project... Drew Haven 2014/02/15 01:23:58 Done. Show quoted text On 2014/02/15 00:26:59, Lei Zhang wrote: > nit: this comment is inconsistent with line 8. We decided to not bother with > "namespace chrome" BTW, since chrome/ is the top level project... Done.
	28

	29 #endif // CHROME_BROWSER_EXTENSIONS_API_IMAGE_WRITER_PRIVATE_ERROR_MESSAGES_H_

OLD	NEW