chrome/utility/chrome_content_utility_ipc_whitelist.cc - Issue 61643015: Adds imageWriterPrivate support for Windows

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/utility/chrome_content_utility_ipc_whitelist.cc

Issue 61643015: Adds imageWriterPrivate support for Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup and now working on Windows with minimal changes. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/image_writer_client.cc ('K') | « chrome/utility/chrome_content_utility_client.cc ('k') | chrome/utility/image_writer/OWNERS » ('j') | chrome/utility/image_writer/image_writer_handler.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/utility/chrome_content_utility_ipc_whitelist.h"	5 #include "chrome/utility/chrome_content_utility_ipc_whitelist.h"

	6 #include "chrome/common/chrome_utility_messages.h"

6	7

7 namespace chrome {	8 namespace chrome {

8	9

9 const uint32 kMessageWhitelist[] = {0};	10 const uint32 kMessageWhitelist[] = {ChromeUtilityMsg_ImageWriter_Cancel::ID,

	11 ChromeUtilityMsg_ImageWriter_Write::ID,

	12 ChromeUtilityMsg_ImageWriter_Verify::ID};
	Matt Perry 2014/02/14 00:16:23 What does this do? What does this do? Drew Haven 2014/02/14 02:32:56 In Windows we have to do our writing to USB device Show quoted text On 2014/02/14 00:16:23, Matt Perry wrote: > What does this do? In Windows we have to do our writing to USB device with elevated privileges. As a security measure we only allow a limited set of approved IPC messages when running elevated, that way we can avoid those operations that we're placing in the utility process because they're buggy/unstable.
10 const size_t kMessageWhitelistSize = arraysize(kMessageWhitelist);	13 const size_t kMessageWhitelistSize = arraysize(kMessageWhitelist);

11	14

12 } // namespace chrome	15 } // namespace chrome

OLD	NEW