src/opts/SkBlurImage_opts_none.cpp - Issue 61643011: SSE2 implementation of RGBA box blurs. This yields ~2X perf improvement on

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/opts/SkBlurImage_opts_none.cpp

Issue 61643011: SSE2 implementation of RGBA box blurs. This yields ~2X perf improvement on (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Add a reinterpret_cast to please MSC. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 /*

	2 * Copyright 2013 The Android Open Source Project

	3 *

	4 * Use of this source code is governed by a BSD-style license that can be

	5 * found in the LICENSE file.

	6 */

	7

	8 #include "SkBlurImage_opts.h"

	9

	10 bool SkBoxBlurGetPlatformProcs(SkBoxBlurProc* boxBlurX,

	11 SkBoxBlurProc* boxBlurY,

	12 SkBoxBlurProc* boxBlurXY);
	mtklein 2013/11/08 18:42:34 Should be { return false; } ? Maybe this file's j Should be { return false; } ? Maybe this file's just not needed? Stephen White 2013/11/08 20:20:49 Yikes, thanks! Yes, it's needed. (I did check that Show quoted text On 2013/11/08 18:42:34, mtklein wrote: > Should be { return false; } ? Maybe this file's just not needed? Yikes, thanks! Yes, it's needed. (I did check that Android built, but it does lazy-loading, so it doesn't fail until runtime.)
OLD	NEW

« src/opts/SkBlurImage_opts_SSE2.cpp ('K') | « src/opts/SkBlurImage_opts_SSE2.cpp ('k') | src/opts/opts_check_SSE2.cpp » ('j') | no next file with comments »