Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: content/browser/renderer_host/render_message_filter.cc

Issue 61643007: Update keygen to use correct NSS slot on ChromeOS multiprofile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync to r235279 Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_message_filter.cc
diff --git a/content/browser/renderer_host/render_message_filter.cc b/content/browser/renderer_host/render_message_filter.cc
index 48866d7a25708946653f4c12739524838e691096..fb9fa75f67bd2e572dc9cee66b13733c8e4e581e 100644
--- a/content/browser/renderer_host/render_message_filter.cc
+++ b/content/browser/renderer_host/render_message_filter.cc
@@ -948,13 +948,37 @@ void RenderMessageFilter::OnKeygen(uint32 key_size_index,
return;
}
+ // Create the KeygenHandler on the IO thread so that we can safely use
+ // ResourceContext to initialize the crypto module delegate (when using NSS).
+ scoped_ptr<net::KeygenHandler> keygen_handler(
+ new net::KeygenHandler(key_size_in_bits, challenge_string, url));
+#if defined(USE_NSS)
+ net::KeygenHandler* keygen_handler_ptr = keygen_handler.get();
+ // Attach a delegate to handle choosing what token to store the generated key
+ // in and authenticating to the token.
+ keygen_handler_ptr->InitializeCryptoModuleDelegate(
+ GetContentClient()->browser()->GetKeygenCryptoModuleDelegate(
+ resource_context_, url),
+ base::Bind(&RenderMessageFilter::PostKeygenToWorkerThread,
+ this,
+ base::Passed(&keygen_handler),
+ reply_msg));
+#else
+ PostKeygenToWorkerThread(keygen_handler.Pass(), reply_msg);
+#endif // defined(USE_NSS)
+}
+
+void RenderMessageFilter::PostKeygenToWorkerThread(
+ scoped_ptr<net::KeygenHandler> keygen_handler,
+ IPC::Message* reply_msg) {
VLOG(1) << "Dispatching keygen task to worker pool.";
// Dispatch to worker pool, so we do not block the IO thread.
if (!base::WorkerPool::PostTask(
FROM_HERE,
- base::Bind(
- &RenderMessageFilter::OnKeygenOnWorkerThread, this,
- key_size_in_bits, challenge_string, url, reply_msg),
+ base::Bind(&RenderMessageFilter::OnKeygenOnWorkerThread,
+ this,
+ base::Passed(&keygen_handler),
+ reply_msg),
true)) {
NOTREACHED() << "Failed to dispatch keygen task to worker pool";
ViewHostMsg_Keygen::WriteReplyParams(reply_msg, std::string());
@@ -964,24 +988,14 @@ void RenderMessageFilter::OnKeygen(uint32 key_size_index,
}
void RenderMessageFilter::OnKeygenOnWorkerThread(
- int key_size_in_bits,
- const std::string& challenge_string,
- const GURL& url,
+ scoped_ptr<net::KeygenHandler> keygen_handler,
IPC::Message* reply_msg) {
DCHECK(reply_msg);
// Generate a signed public key and challenge, then send it back.
- net::KeygenHandler keygen_handler(key_size_in_bits, challenge_string, url);
-
-#if defined(USE_NSS)
- // Attach a password delegate so we can authenticate.
- keygen_handler.set_crypto_module_password_delegate(
- GetContentClient()->browser()->GetCryptoPasswordDelegate(url));
-#endif // defined(USE_NSS)
-
ViewHostMsg_Keygen::WriteReplyParams(
reply_msg,
- keygen_handler.GenKeyAndSignChallenge());
+ keygen_handler->GenKeyAndSignChallenge());
Send(reply_msg);
}

Powered by Google App Engine
This is Rietveld 408576698