Issue 61643004: Update gm flags so that it can be run without a pdf rasterizer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 61643004: Update gm flags so that it can be run without a pdf rasterizer. (Closed)

Created:
7 years, 1 month ago by vandebo (ex-Chrome)

Modified:
7 years, 1 month ago

Reviewers:
edisonn, robertphillips

CC:
skia-review_googlegroups.com, edisonn, borenet

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Update gm flags so that it can be run without a pdf rasterizer. BUG=1806 R=edisonn@google.com Committed: https://code.google.com/p/skia/source/detail?r=12157

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -15 lines)			Patch
	M	gm/gmmain.cpp	View		2 chunks	+15 lines, -15 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

vandebo (ex-Chrome)

Committed patchset #1 manually as r12157 (presubmit successful).

7 years, 1 month ago (2013-11-06 16:33:09 UTC) #3

robertphillips

I think there may be a problem. https://codereview.chromium.org/61643004/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/61643004/diff/1/gm/gmmain.cpp#newcode2005 gm/gmmain.cpp:2005: Won't this ...

7 years, 1 month ago (2013-11-06 16:36:13 UTC) #4

vandebo (ex-Chrome)

7 years, 1 month ago (2013-11-06 16:46:40 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/61643004/diff/1/gm/gmmain.cpp
File gm/gmmain.cpp (right):

https://codereview.chromium.org/61643004/diff/1/gm/gmmain.cpp#newcode2005
gm/gmmain.cpp:2005: 
On 2013/11/06 16:36:13, robertphillips wrote:
> Won't this now not use a rasterizer by default?

I changed the default value of the flag to "default", that will get caught by
this case, which adds all the known rasterizers.  If you specify the flag, with
something other than "default" or without anythingthe else starting on line 2013
will run.  There, if the list is empty, no rasterizer is added, if not,
rasterizers are selected as they were before.

Expand Messages | Collapse Messages