Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 616183002: Revert of Pass initDataType instead of contentType on OnNeedKey(). (Closed)

Created:
6 years, 2 months ago by Zhenyao Mo
Modified:
6 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, eme-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Pass initDataType instead of contentType on OnNeedKey(). (patchset #4 id:60001 of https://codereview.chromium.org/611513005/) Reason for revert: This broke media/encrypted-media/encrypted-media-needkey.html on Linux (at least) Original issue's description: > Pass initDataType instead of contentType to OnNeedKey(). > > BUG=224786 > > Committed: https://crrev.com/2983dc91cc0bc7be6014f4bfc5cb19cc6e262a0b > Cr-Commit-Position: refs/heads/master@{#297523} TBR=ddorwin@chromium.org,sandersd@chromium.org NOTREECHECKS=true NOTRY=true BUG=224786 Committed: https://crrev.com/de394fa4553674e0aa522ce7c3483394f0f40d3d Cr-Commit-Position: refs/heads/master@{#297538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -17 lines) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/media/crypto/encrypted_media_player_support_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/media/crypto/proxy_decryptor.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/crypto/proxy_decryptor.cc View 2 chunks +12 lines, -1 line 0 comments Download
M media/filters/pipeline_integration_test.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/formats/webm/webm_crypto_helpers.h View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Zhenyao Mo
Created Revert of Pass initDataType instead of contentType on OnNeedKey().
6 years, 2 months ago (2014-09-30 23:18:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616183002/1
6 years, 2 months ago (2014-09-30 23:19:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 04cf114236e2d75331784ce85b8e250b8017e2cb
6 years, 2 months ago (2014-09-30 23:20:37 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 23:21:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de394fa4553674e0aa522ce7c3483394f0f40d3d
Cr-Commit-Position: refs/heads/master@{#297538}

Powered by Google App Engine
This is Rietveld 408576698