Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1369)

Unified Diff: content/common/frame_messages.h

Issue 616133002: Make RenderFrame(Host) own a RenderWidget(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed output surface problems, combined RenderFrame and RenderWidget creation Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index f4b08258ba9aefd3c76491428158f2c42009ff79..92a02480b75300f1684fd16415ca9d3afd73515e 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -173,6 +173,19 @@ IPC_STRUCT_BEGIN_WITH_PARENT(FrameHostMsg_DidCommitProvisionalLoad_Params,
IPC_STRUCT_MEMBER(int, render_view_routing_id)
IPC_STRUCT_END()
+IPC_STRUCT_BEGIN(FrameMsg_NewFrame_WidgetParams)
+ // Gives the routing ID for the RenderWidget that will be attached to the
+ // new RenderFrame. If the RenderFrame does not need a RenderWidget, this
+ // is MSG_ROUTING_NONE and the other parameters are not read.
+ IPC_STRUCT_MEMBER(int, routing_id)
+
+ // Identifier for the output surface for the new RenderWidget.
+ IPC_STRUCT_MEMBER(int, surface_id)
+
+ // Tells the new RenderWidget whether it is initially hidden.
+ IPC_STRUCT_MEMBER(bool, hidden)
+IPC_STRUCT_END()
+
IPC_STRUCT_BEGIN(FrameMsg_Navigate_Params)
// The page_id for this navigation, or -1 if it is a new navigation. Back,
// Forward, and Reload navigations should have a valid page_id. If the load
@@ -368,9 +381,10 @@ IPC_MESSAGE_ROUTED0(FrameMsg_DisownOpener)
// Instructs the renderer to create a new RenderFrame object with |routing_id|.
// The new frame should be created as a child of the object identified by
// |parent_routing_id| or as top level if that is MSG_ROUTING_NONE.
-IPC_MESSAGE_CONTROL2(FrameMsg_NewFrame,
+IPC_MESSAGE_CONTROL3(FrameMsg_NewFrame,
int /* routing_id */,
- int /* parent_routing_id */)
+ int /* parent_routing_id */,
+ FrameMsg_NewFrame_WidgetParams /* params */)
nasko 2014/10/02 20:41:44 nit: widget_params
kenrb 2014/10/03 17:23:32 Done.
// Instructs the renderer to create a new RenderFrameProxy object with
// |routing_id|. The new proxy should be created as a child of the object

Powered by Google App Engine
This is Rietveld 408576698