Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: content/common/frame_messages.h

Issue 616133002: Make RenderFrame(Host) own a RenderWidget(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved InitForFrame call, addressed other comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index 31fa6039d956dcf194fc077a6440a4dd1cce9896..c5ab4873f878ea9375a0aecd922818126432010e 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -228,6 +228,19 @@ IPC_STRUCT_TRAITS_BEGIN(content::FrameReplicationState)
IPC_STRUCT_TRAITS_MEMBER(origin)
IPC_STRUCT_TRAITS_END()
+IPC_STRUCT_BEGIN(FrameMsg_NewFrame_WidgetParams)
+// Gives the routing ID for the RenderWidget that will be attached to the
+// new RenderFrame. If the RenderFrame does not need a RenderWidget, this
+// is MSG_ROUTING_NONE and the other parameters are not read.
+IPC_STRUCT_MEMBER(int, routing_id)
Charlie Reis 2015/01/15 23:06:27 nit: These still need a 2 space indent, for consis
kenrb 2015/01/16 17:44:00 Done.
+
+// Identifier for the output surface for the new RenderWidget.
+IPC_STRUCT_MEMBER(int, surface_id)
+
+// Tells the new RenderWidget whether it is initially hidden.
+IPC_STRUCT_MEMBER(bool, hidden)
+IPC_STRUCT_END()
+
IPC_STRUCT_BEGIN(FrameMsg_Navigate_Params)
// TODO(clamy): investigate which parameters are also needed in PlzNavigate
// and move them to the appropriate NavigationParams struct.
@@ -385,10 +398,11 @@ IPC_MESSAGE_ROUTED0(FrameMsg_DisownOpener)
// |parent_routing_id| or as top level if that is MSG_ROUTING_NONE.
// If a valid |proxy_routing_id| is provided, the new frame will be configured
// to replace the proxy on commit.
-IPC_MESSAGE_CONTROL3(FrameMsg_NewFrame,
+IPC_MESSAGE_CONTROL4(FrameMsg_NewFrame,
int /* routing_id */,
int /* parent_routing_id */,
- int /* proxy_routing_id */)
+ int /* proxy_routing_id */,
+ FrameMsg_NewFrame_WidgetParams /* widget_params */)
// Instructs the renderer to create a new RenderFrameProxy object with
// |routing_id|. The new proxy should be created as a child of the object

Powered by Google App Engine
This is Rietveld 408576698