content/renderer/render_thread_impl.cc - Issue 616133002: Make RenderFrame(Host) own a RenderWidget(Host).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_thread_impl.cc

Issue 616133002: Make RenderFrame(Host) own a RenderWidget(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test update, RWH lifetime fix Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_thread_impl.cc

diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc

index a2ce311839d28b20bd9436325f8174c1b8915933..16bf9c1d1d9ef6a2b0d6de75fc2dd4420c51b467 100644

--- a/content/renderer/render_thread_impl.cc

+++ b/content/renderer/render_thread_impl.cc

@@ -1483,8 +1483,11 @@ bool RenderThreadImpl::OnControlMessageReceived(const IPC::Message& msg) {

void RenderThreadImpl::OnCreateNewFrame(int routing_id,

int parent_routing_id,

- int proxy_routing_id) {

- RenderFrameImpl::CreateFrame(routing_id, parent_routing_id, proxy_routing_id);

+ int proxy_routing_id,

+ FrameMsg_NewFrame_WidgetParams params) {

+ CompositorDependencies* compositor_deps = this;

+ RenderFrameImpl::CreateFrame(routing_id, parent_routing_id, proxy_routing_id,

+ compositor_deps, params);

}

void RenderThreadImpl::OnCreateNewFrameProxy(