Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.h

Issue 616133002: Make RenderFrame(Host) own a RenderWidget(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test update, RWH lifetime fix Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.h
diff --git a/content/browser/renderer_host/render_widget_host_impl.h b/content/browser/renderer_host/render_widget_host_impl.h
index d42c1c1062aa9bce26012e5ef0a3a56f74af2ee8..b1940d7fdfb198263da1066b964e150e165bb9bc 100644
--- a/content/browser/renderer_host/render_widget_host_impl.h
+++ b/content/browser/renderer_host/render_widget_host_impl.h
@@ -190,6 +190,9 @@ class CONTENT_EXPORT RenderWidgetHostImpl
// menus, and other times when the renderer initiates creating an object.
virtual void Init();
+ // Initializes a RenderWidgetHost that is attached to a Frame.
nasko 2015/01/14 20:08:05 nit: s/Frame/RenderFrameHost/
kenrb 2015/01/15 22:41:46 Done.
+ void InitForFrame();
+
// Tells the renderer to die and then calls Destroy().
virtual void Shutdown();
@@ -823,6 +826,9 @@ class CONTENT_EXPORT RenderWidgetHostImpl
base::Callback<void(const unsigned char*, size_t)> > PendingSnapshotMap;
PendingSnapshotMap pending_browser_snapshots_;
+ // Ownership by RenderFrameHost has lifetime implications.
nasko 2015/01/14 20:08:04 Can you add what those implications are?
kenrb 2015/01/15 22:41:46 Done.
+ bool owned_by_render_frame_host_;
+
base::WeakPtrFactory<RenderWidgetHostImpl> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl);

Powered by Google App Engine
This is Rietveld 408576698