Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: content/renderer/render_widget.h

Issue 616133002: Make RenderFrame(Host) own a RenderWidget(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments addressed Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.h
diff --git a/content/renderer/render_widget.h b/content/renderer/render_widget.h
index 90c4f7223362d3ff6e1c3df565e3da091bbb76a8..3dd368d34b1fae3f6d6fe5275fa9034f9864d76f 100644
--- a/content/renderer/render_widget.h
+++ b/content/renderer/render_widget.h
@@ -97,6 +97,13 @@ class CONTENT_EXPORT RenderWidget
blink::WebPopupType popup_type,
const blink::WebScreenInfo& screen_info);
+ // Creates a new RenderWidget that will be attached to a RenderFrame.
+ // TODO(kenrb): It has its own routing_id for now but this should
Charlie Reis 2014/10/02 00:06:57 This TODO can probably be removed as well?
kenrb 2014/10/02 20:20:48 Done.
+ // eventually change.
+ static RenderWidget* CreateForFrame(int routing_id,
+ bool hidden,
+ const blink::WebScreenInfo& screen_info);
+
// Creates a WebWidget based on the popup type.
static blink::WebWidget* CreateWebWidget(RenderWidget* render_widget);
@@ -121,6 +128,9 @@ class CONTENT_EXPORT RenderWidget
return host_context_menu_location_;
}
+ // ScreenInfo exposed so it can be passed to subframe RenderWidgets.
+ blink::WebScreenInfo screen_info() const { return screen_info_; }
+
// Functions to track out-of-process frames for special notifications.
void RegisterRenderFrameProxy(RenderFrameProxy* proxy);
void UnregisterRenderFrameProxy(RenderFrameProxy* proxy);

Powered by Google App Engine
This is Rietveld 408576698