Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: content/renderer/render_widget.cc

Issue 616133002: Make RenderFrame(Host) own a RenderWidget(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git cl format, changed WebWidget creation Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/renderer/render_frame_impl.cc ('K') | « content/renderer/render_widget.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 537694ea95cf7573da4334b78af6a6b0059e8990..ec9e095818bda9c2974ddb95c27daaf36ebb3932 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -60,11 +60,14 @@
#include "third_party/WebKit/public/platform/WebSize.h"
#include "third_party/WebKit/public/platform/WebString.h"
#include "third_party/WebKit/public/web/WebDeviceEmulationParams.h"
+#include "third_party/WebKit/public/web/WebFrameWidget.h"
+#include "third_party/WebKit/public/web/WebLocalFrame.h"
#include "third_party/WebKit/public/web/WebPagePopup.h"
#include "third_party/WebKit/public/web/WebPopupMenu.h"
#include "third_party/WebKit/public/web/WebPopupMenuInfo.h"
#include "third_party/WebKit/public/web/WebRange.h"
#include "third_party/WebKit/public/web/WebRuntimeFeatures.h"
+#include "third_party/WebKit/public/web/WebView.h"
#include "third_party/skia/include/core/SkShader.h"
#include "ui/base/ui_base_switches.h"
#include "ui/gfx/frame_time.h"
@@ -533,7 +536,28 @@ RenderWidget* RenderWidget::Create(int32 opener_id,
}
// static
-WebWidget* RenderWidget::CreateWebWidget(RenderWidget* render_widget) {
+RenderWidget* RenderWidget::CreateForFrame(
+ int routing_id,
+ int surface_id,
+ bool hidden,
+ const blink::WebScreenInfo& screen_info,
+ blink::WebLocalFrame* frame) {
+ DCHECK(routing_id != MSG_ROUTING_NONE);
Charlie Reis 2014/12/18 18:04:14 nit: DCHECK_NE
kenrb 2015/01/05 21:15:31 Done.
+ scoped_refptr<RenderWidget> widget(new RenderWidget(
+ blink::WebPopupTypeNone, screen_info, false, hidden, false));
+ widget->routing_id_ = routing_id;
+ widget->surface_id_ = surface_id;
+ if (widget->DoInit(MSG_ROUTING_NONE,
+ RenderWidget::CreateWebFrameWidget(widget.get(), frame),
+ nullptr)) {
+ widget->CompleteInit();
+ return widget.get();
+ }
+ return NULL;
nasko 2014/12/17 22:51:30 nullptr
kenrb 2015/01/05 21:15:31 Done.
+}
+
+// static
+blink::WebWidget* RenderWidget::CreateWebWidget(RenderWidget* render_widget) {
switch (render_widget->popup_type_) {
case blink::WebPopupTypeNone: // Nothing to create.
break;
@@ -548,6 +572,13 @@ WebWidget* RenderWidget::CreateWebWidget(RenderWidget* render_widget) {
return NULL;
}
+// static
+blink::WebWidget* RenderWidget::CreateWebFrameWidget(
+ RenderWidget* render_widget,
+ blink::WebLocalFrame* frame) {
+ return blink::WebFrameWidget::create(render_widget, frame);
+}
+
bool RenderWidget::Init(int32 opener_id) {
return DoInit(opener_id,
RenderWidget::CreateWebWidget(this),
@@ -565,7 +596,10 @@ bool RenderWidget::DoInit(int32 opener_id,
webwidget_ = web_widget;
- bool result = RenderThread::Get()->Send(create_widget_message);
+ bool result = true;
+ if (create_widget_message)
+ result = RenderThread::Get()->Send(create_widget_message);
+
if (result) {
RenderThread::Get()->AddRoute(routing_id_, this);
// Take a reference on behalf of the RenderThread. This will be balanced
« content/renderer/render_frame_impl.cc ('K') | « content/renderer/render_widget.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698