content/browser/frame_host/render_widget_host_view_child_frame.cc - Issue 616133002: Make RenderFrame(Host) own a RenderWidget(Host).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 616133002: Make RenderFrame(Host) own a RenderWidget(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git cl format, changed WebWidget creation Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_widget_host_view_child_frame.cc

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc

index cff6c4dcdacc9121f686a6764f6fc1e12d998071..a47cf3a8787a00720afac65237d18bb09a958c14 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc

+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc

@@ -153,7 +153,7 @@ void RenderWidgetHostViewChildFrame::TextInputTypeChanged(

ui::TextInputMode input_mode,

bool can_compose_inline,

int flags) {

- NOTREACHED();

+ // TODO: Implement.

Charlie Reis 2014/12/18 18:04:13 nit: TODO(kenrb) (All TODOs in Chromium code shou

kenrb 2015/01/05 21:15:30 Done.

}

void RenderWidgetHostViewChildFrame::RenderProcessGone(