Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1982)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 616133002: Make RenderFrame(Host) own a RenderWidget(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a conflict with the RF creation flag word Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index e3bc2e89a134635bff096a58617184f62a9b0d29..53738ffa6448b1076588f85085dc0578e1333cef 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -115,6 +115,7 @@
#include "third_party/WebKit/public/platform/WebVector.h"
#include "third_party/WebKit/public/web/WebColorSuggestion.h"
#include "third_party/WebKit/public/web/WebDocument.h"
+#include "third_party/WebKit/public/web/WebFrameWidget.h"
#include "third_party/WebKit/public/web/WebGlyphCache.h"
#include "third_party/WebKit/public/web/WebLocalFrame.h"
#include "third_party/WebKit/public/web/WebMediaStreamRegistry.h"
@@ -500,9 +501,11 @@ RenderFrameImpl* RenderFrameImpl::FromRoutingID(int32 routing_id) {
}
// static
-void RenderFrameImpl::CreateFrame(int routing_id,
- int parent_routing_id,
- int proxy_routing_id) {
+void RenderFrameImpl::CreateFrame(
+ int routing_id,
+ int parent_routing_id,
+ int proxy_routing_id,
+ const FrameMsg_NewFrame_WidgetParams& params) {
// TODO(nasko): For now, this message is only sent for subframes, as the
// top level frame is created when the RenderView is created through the
// ViewMsg_New IPC.
@@ -532,6 +535,24 @@ void RenderFrameImpl::CreateFrame(int routing_id,
web_frame->initializeToReplaceRemoteFrame(proxy->web_frame());
}
render_frame->SetWebFrame(web_frame);
+
+ if (params.routing_id != MSG_ROUTING_NONE) {
+ render_frame->render_widget_ = RenderWidget::CreateForFrame(
+ params.routing_id,
+ params.surface_id,
+ params.hidden,
+ render_frame->render_view_->screen_info(),
+ render_frame->render_view_->GetWebView());
+ if (render_frame->render_widget_) {
+ static_cast<blink::WebFrameWidget*>(render_frame->render_widget_->
+ webwidget())->setLocalRoot(web_frame);
+ }
+ // TODO(kenrb): Observing shouldn't be necessary when we sort out
+ // WasShown and WasHidden, separating page-level visibility from
+ // frame-level visibility.
+ render_frame->render_widget_->RegisterRenderFrame(render_frame);
+ }
+
render_frame->Initialize();
}
@@ -3461,6 +3482,14 @@ void RenderFrameImpl::WasHidden() {
}
void RenderFrameImpl::WasShown() {
+ // TODO(kenrb): Need to figure out how to do this better. Should
+ // VisibilityState remain a page-level concept or move to frames?
+ // The semantics of 'Show' might have to change here.
+ if (render_widget_) {
+ render_view()->webview()->setVisibilityState(
+ blink::WebPageVisibilityStateVisible,
+ false);
+ }
FOR_EACH_OBSERVER(RenderFrameObserver, observers_, WasShown());
}

Powered by Google App Engine
This is Rietveld 408576698