Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Unified Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 616133002: Make RenderFrame(Host) own a RenderWidget(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager.h
diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h
index 48a5f24b6f4e79f999567b0770c82fd6565c22ae..c6dcd69cb88b94fcfa183a1760609a8a42a1542c 100644
--- a/content/browser/frame_host/render_frame_host_manager.h
+++ b/content/browser/frame_host/render_frame_host_manager.h
@@ -44,6 +44,14 @@ class TestWebContents;
class WebUIImpl;
struct NavigationBeforeCommitInfo;
+// Flag arguments for RenderFrameHostManager::CreateRenderFrame.
+enum CreateRenderFrameFlags {
+ SWAPPED_OUT = 1 << 0,
Charlie Reis 2014/10/01 17:01:09 We typically comment each member of the enum here,
kenrb 2014/10/01 19:27:51 Comments added.
+ FOR_MAIN_FRAME_NAVIGATION = 1 << 1,
+ HIDDEN = 1 << 2,
+ CREATE_RENDER_WIDGET_HOST = 1 << 3
+};
+
// Manages RenderFrameHosts for a FrameTreeNode. This class acts as a state
// machine to make cross-process navigations in a frame possible.
class CONTENT_EXPORT RenderFrameHostManager : public NotificationObserver {
@@ -256,9 +264,7 @@ class CONTENT_EXPORT RenderFrameHostManager : public NotificationObserver {
// Returns the routing id of the *view* associated with the frame.
int CreateRenderFrame(SiteInstance* instance,
int opener_route_id,
- bool swapped_out,
- bool for_main_frame_navigation,
- bool hidden);
+ int flags);
// Helper method to create and initialize a RenderFrameProxyHost and return
// its routing id.

Powered by Google App Engine
This is Rietveld 408576698