Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Side by Side Diff: content/browser/frame_host/render_frame_host_factory.cc

Issue 616133002: Make RenderFrame(Host) own a RenderWidget(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test update, RWH lifetime fix Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_frame_host_factory.h" 5 #include "content/browser/frame_host/render_frame_host_factory.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "content/browser/frame_host/frame_tree_node.h" 8 #include "content/browser/frame_host/frame_tree_node.h"
9 #include "content/browser/frame_host/render_frame_host_impl.h" 9 #include "content/browser/frame_host/render_frame_host_impl.h"
10 10
11 namespace content { 11 namespace content {
12 12
13 // static 13 // static
14 RenderFrameHostFactory* RenderFrameHostFactory::factory_ = NULL; 14 RenderFrameHostFactory* RenderFrameHostFactory::factory_ = NULL;
15 15
16 // static 16 // static
17 scoped_ptr<RenderFrameHostImpl> RenderFrameHostFactory::Create( 17 scoped_ptr<RenderFrameHostImpl> RenderFrameHostFactory::Create(
18 RenderViewHostImpl* render_view_host, 18 RenderViewHostImpl* render_view_host,
19 RenderFrameHostDelegate* delegate, 19 RenderFrameHostDelegate* delegate,
20 RenderWidgetHostDelegate* rwh_delegate,
20 FrameTree* frame_tree, 21 FrameTree* frame_tree,
21 FrameTreeNode* frame_tree_node, 22 FrameTreeNode* frame_tree_node,
22 int routing_id, 23 int routing_id,
23 int flags) { 24 int flags) {
24 if (factory_) { 25 if (factory_) {
25 return factory_->CreateRenderFrameHost(render_view_host, delegate, 26 return factory_->CreateRenderFrameHost(
26 frame_tree, frame_tree_node, 27 render_view_host, delegate, rwh_delegate, frame_tree,
nasko 2015/01/14 20:08:04 nit: This doesn't seem right for indent. It should
kenrb 2015/01/15 22:41:46 Done.
27 routing_id, flags).Pass(); 28 frame_tree_node, routing_id, flags).Pass();
dcheng 2015/01/14 20:49:02 Drive-by: Pass() should not be needed here (and pr
kenrb 2015/01/15 22:41:46 Done.
28 } 29 }
29 return make_scoped_ptr(new RenderFrameHostImpl(render_view_host, delegate, 30 return make_scoped_ptr(
30 frame_tree, frame_tree_node, 31 new RenderFrameHostImpl(render_view_host, delegate, rwh_delegate,
31 routing_id, flags)); 32 frame_tree, frame_tree_node, routing_id, flags));
32 } 33 }
33 34
34 // static 35 // static
35 void RenderFrameHostFactory::RegisterFactory(RenderFrameHostFactory* factory) { 36 void RenderFrameHostFactory::RegisterFactory(RenderFrameHostFactory* factory) {
36 DCHECK(!factory_) << "Can't register two factories at once."; 37 DCHECK(!factory_) << "Can't register two factories at once.";
37 factory_ = factory; 38 factory_ = factory;
38 } 39 }
39 40
40 // static 41 // static
41 void RenderFrameHostFactory::UnregisterFactory() { 42 void RenderFrameHostFactory::UnregisterFactory() {
42 DCHECK(factory_) << "No factory to unregister."; 43 DCHECK(factory_) << "No factory to unregister.";
43 factory_ = NULL; 44 factory_ = NULL;
44 } 45 }
45 46
46 } // namespace content 47 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698