Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 616133002: Make RenderFrame(Host) own a RenderWidget(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments addressed Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_frame_host_impl.h" 5 #include "content/browser/frame_host/render_frame_host_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/containers/hash_tables.h" 9 #include "base/containers/hash_tables.h"
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 725 matching lines...) Expand 10 before | Expand all | Expand 10 after
736 // filenames it can't access in a future session restore. 736 // filenames it can't access in a future session restore.
737 if (!render_view_host_->CanAccessFilesOfPageState( 737 if (!render_view_host_->CanAccessFilesOfPageState(
738 validated_params.page_state)) { 738 validated_params.page_state)) {
739 GetProcess()->ReceivedBadMessage(); 739 GetProcess()->ReceivedBadMessage();
740 return; 740 return;
741 } 741 }
742 742
743 frame_tree_node()->navigator()->DidNavigate(this, validated_params); 743 frame_tree_node()->navigator()->DidNavigate(this, validated_params);
744 } 744 }
745 745
746 void RenderFrameHostImpl::CreateRenderWidgetHost(
747 RenderWidgetHostDelegate* delegate,
748 bool hidden) {
749 DCHECK(!render_widget_host_);
750 int render_widget_host_routing_id = GetProcess()->GetNextRoutingID();
751 render_widget_host_.reset(
752 new RenderWidgetHostImpl(delegate,
753 GetProcess(),
754 render_widget_host_routing_id,
755 hidden));
756
757 new RenderWidgetHostViewChildFrame(render_widget_host_.get());
758
759 Send(new FrameMsg_NewWidgetForFrame(routing_id_,
760 render_widget_host_routing_id,
761 hidden));
762 }
763
746 RenderWidgetHostImpl* RenderFrameHostImpl::GetRenderWidgetHost() { 764 RenderWidgetHostImpl* RenderFrameHostImpl::GetRenderWidgetHost() {
765 if (render_widget_host_)
766 return render_widget_host_.get();
767
768 // TODO(kenrb): When RenderViewHost no longer inherits RenderWidgetHost,
769 // we can remove this fallback. Currently it is only used for the main
770 // frame.
747 return static_cast<RenderWidgetHostImpl*>(render_view_host_); 771 return static_cast<RenderWidgetHostImpl*>(render_view_host_);
748 } 772 }
749 773
750 int RenderFrameHostImpl::GetEnabledBindings() { 774 int RenderFrameHostImpl::GetEnabledBindings() {
751 return render_view_host_->GetEnabledBindings(); 775 return render_view_host_->GetEnabledBindings();
752 } 776 }
753 777
754 void RenderFrameHostImpl::OnCrossSiteResponse( 778 void RenderFrameHostImpl::OnCrossSiteResponse(
755 const GlobalRequestID& global_request_id, 779 const GlobalRequestID& global_request_id,
756 scoped_ptr<CrossSiteTransferringRequest> cross_site_transferring_request, 780 scoped_ptr<CrossSiteTransferringRequest> cross_site_transferring_request,
(...skipping 763 matching lines...) Expand 10 before | Expand all | Expand 10 after
1520 // Clear any state if a pending navigation is canceled or preempted. 1544 // Clear any state if a pending navigation is canceled or preempted.
1521 if (suspended_nav_params_) 1545 if (suspended_nav_params_)
1522 suspended_nav_params_.reset(); 1546 suspended_nav_params_.reset();
1523 1547
1524 TRACE_EVENT_ASYNC_END0("navigation", 1548 TRACE_EVENT_ASYNC_END0("navigation",
1525 "RenderFrameHostImpl navigation suspended", this); 1549 "RenderFrameHostImpl navigation suspended", this);
1526 navigations_suspended_ = false; 1550 navigations_suspended_ = false;
1527 } 1551 }
1528 1552
1529 } // namespace content 1553 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698