Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 616133002: Make RenderFrame(Host) own a RenderWidget(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a conflict with the RF creation flag word Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_frame_host_impl.h" 5 #include "content/browser/frame_host/render_frame_host_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/containers/hash_tables.h" 9 #include "base/containers/hash_tables.h"
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 int routing_id) { 112 int routing_id) {
113 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 113 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
114 RoutingIDFrameMap* frames = g_routing_id_frame_map.Pointer(); 114 RoutingIDFrameMap* frames = g_routing_id_frame_map.Pointer();
115 RoutingIDFrameMap::iterator it = frames->find( 115 RoutingIDFrameMap::iterator it = frames->find(
116 RenderFrameHostID(process_id, routing_id)); 116 RenderFrameHostID(process_id, routing_id));
117 return it == frames->end() ? NULL : it->second; 117 return it == frames->end() ? NULL : it->second;
118 } 118 }
119 119
120 RenderFrameHostImpl::RenderFrameHostImpl(RenderViewHostImpl* render_view_host, 120 RenderFrameHostImpl::RenderFrameHostImpl(RenderViewHostImpl* render_view_host,
121 RenderFrameHostDelegate* delegate, 121 RenderFrameHostDelegate* delegate,
122 RenderWidgetHostDelegate* rwh_delegate,
122 FrameTree* frame_tree, 123 FrameTree* frame_tree,
123 FrameTreeNode* frame_tree_node, 124 FrameTreeNode* frame_tree_node,
124 int routing_id, 125 int routing_id,
125 int flags) 126 int flags)
126 : render_view_host_(render_view_host), 127 : render_view_host_(render_view_host),
127 delegate_(delegate), 128 delegate_(delegate),
128 cross_process_frame_connector_(NULL), 129 cross_process_frame_connector_(NULL),
129 render_frame_proxy_host_(NULL), 130 render_frame_proxy_host_(NULL),
130 frame_tree_(frame_tree), 131 frame_tree_(frame_tree),
131 frame_tree_node_(frame_tree_node), 132 frame_tree_node_(frame_tree_node),
132 routing_id_(routing_id), 133 routing_id_(routing_id),
133 render_frame_created_(false), 134 render_frame_created_(false),
134 navigations_suspended_(false), 135 navigations_suspended_(false),
135 is_waiting_for_beforeunload_ack_(false), 136 is_waiting_for_beforeunload_ack_(false),
136 unload_ack_is_for_cross_site_transition_(false), 137 unload_ack_is_for_cross_site_transition_(false),
137 accessibility_reset_token_(0), 138 accessibility_reset_token_(0),
138 accessibility_reset_count_(0), 139 accessibility_reset_count_(0),
139 no_create_browser_accessibility_manager_for_testing_(false), 140 no_create_browser_accessibility_manager_for_testing_(false),
140 weak_ptr_factory_(this) { 141 weak_ptr_factory_(this) {
141 bool is_swapped_out = !!(flags & CREATE_RF_SWAPPED_OUT); 142 bool is_swapped_out = !!(flags & CREATE_RF_SWAPPED_OUT);
143 bool hidden = !!(flags & CREATE_RF_HIDDEN);
142 frame_tree_->RegisterRenderFrameHost(this); 144 frame_tree_->RegisterRenderFrameHost(this);
143 GetProcess()->AddRoute(routing_id_, this); 145 GetProcess()->AddRoute(routing_id_, this);
144 g_routing_id_frame_map.Get().insert(std::make_pair( 146 g_routing_id_frame_map.Get().insert(std::make_pair(
145 RenderFrameHostID(GetProcess()->GetID(), routing_id_), 147 RenderFrameHostID(GetProcess()->GetID(), routing_id_),
146 this)); 148 this));
147 149
148 if (is_swapped_out) { 150 if (is_swapped_out) {
149 rfh_state_ = STATE_SWAPPED_OUT; 151 rfh_state_ = STATE_SWAPPED_OUT;
150 } else { 152 } else {
151 rfh_state_ = STATE_DEFAULT; 153 rfh_state_ = STATE_DEFAULT;
152 GetSiteInstance()->increment_active_frame_count(); 154 GetSiteInstance()->increment_active_frame_count();
153 } 155 }
154 156
155 SetUpMojoIfNeeded(); 157 SetUpMojoIfNeeded();
156 swapout_event_monitor_timeout_.reset(new TimeoutMonitor(base::Bind( 158 swapout_event_monitor_timeout_.reset(new TimeoutMonitor(base::Bind(
157 &RenderFrameHostImpl::OnSwappedOut, weak_ptr_factory_.GetWeakPtr()))); 159 &RenderFrameHostImpl::OnSwappedOut, weak_ptr_factory_.GetWeakPtr())));
160
161 if (flags & CREATE_RF_NEEDS_RENDER_WIDGET_HOST) {
162 render_widget_host_.reset(
163 new RenderWidgetHostImpl(rwh_delegate,
164 GetProcess(),
165 MSG_ROUTING_NONE,
166 hidden));
167 render_widget_host_->InitForFrame();
168 }
158 } 169 }
159 170
160 RenderFrameHostImpl::~RenderFrameHostImpl() { 171 RenderFrameHostImpl::~RenderFrameHostImpl() {
161 GetProcess()->RemoveRoute(routing_id_); 172 GetProcess()->RemoveRoute(routing_id_);
162 g_routing_id_frame_map.Get().erase( 173 g_routing_id_frame_map.Get().erase(
163 RenderFrameHostID(GetProcess()->GetID(), routing_id_)); 174 RenderFrameHostID(GetProcess()->GetID(), routing_id_));
164 175
165 if (delegate_) 176 if (delegate_)
166 delegate_->RenderFrameDeleted(this); 177 delegate_->RenderFrameDeleted(this);
167 178
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
502 513
503 // The process may (if we're sharing a process with another host that already 514 // The process may (if we're sharing a process with another host that already
504 // initialized it) or may not (we have our own process or the old process 515 // initialized it) or may not (we have our own process or the old process
505 // crashed) have been initialized. Calling Init multiple times will be 516 // crashed) have been initialized. Calling Init multiple times will be
506 // ignored, so this is safe. 517 // ignored, so this is safe.
507 if (!GetProcess()->Init()) 518 if (!GetProcess()->Init())
508 return false; 519 return false;
509 520
510 DCHECK(GetProcess()->HasConnection()); 521 DCHECK(GetProcess()->HasConnection());
511 522
512 Send(new FrameMsg_NewFrame(routing_id_, parent_routing_id, proxy_routing_id)); 523 FrameMsg_NewFrame_WidgetParams widget_params;
524 if (render_widget_host_) {
525 widget_params.routing_id = render_widget_host_->GetRoutingID();
526 widget_params.surface_id = render_widget_host_->surface_id();
527 widget_params.hidden = render_widget_host_->is_hidden();
528 } else {
529 // MSG_ROUTING_NONE will prevent a new RenderWidget from being created in
530 // the renderer process.
531 widget_params.routing_id = MSG_ROUTING_NONE;
532 widget_params.surface_id = 0;
533 widget_params.hidden = true;
534 }
535
536 Send(new FrameMsg_NewFrame(routing_id_,
537 parent_routing_id,
538 proxy_routing_id,
539 widget_params));
540
541 // The lifetime of the view gets tied to the lifetime of the
542 // current render process for this RenderFrameHost.
543 if (render_widget_host_) {
544 RenderWidgetHostView* rwhv = new RenderWidgetHostViewChildFrame(
545 render_widget_host_.get());
546 rwhv->Hide();
547 }
513 548
514 // The renderer now has a RenderFrame for this RenderFrameHost. Note that 549 // The renderer now has a RenderFrame for this RenderFrameHost. Note that
515 // this path is only used for out-of-process iframes. Main frame RenderFrames 550 // this path is only used for out-of-process iframes. Main frame RenderFrames
516 // are created with their RenderView, and same-site iframes are created at the 551 // are created with their RenderView, and same-site iframes are created at the
517 // time of OnCreateChildFrame. 552 // time of OnCreateChildFrame.
518 set_render_frame_created(true); 553 set_render_frame_created(true);
519 554
520 return true; 555 return true;
521 } 556 }
522 557
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
722 757
723 void RenderFrameHostImpl::OnDidDropNavigation() { 758 void RenderFrameHostImpl::OnDidDropNavigation() {
724 // At the end of Navigate(), the delegate's DidStartLoading is called to force 759 // At the end of Navigate(), the delegate's DidStartLoading is called to force
725 // the spinner to start, even if the renderer didn't yet begin the load. If it 760 // the spinner to start, even if the renderer didn't yet begin the load. If it
726 // turns out that the renderer dropped the navigation, we need to turn off the 761 // turns out that the renderer dropped the navigation, we need to turn off the
727 // spinner. 762 // spinner.
728 delegate_->DidStopLoading(this); 763 delegate_->DidStopLoading(this);
729 } 764 }
730 765
731 RenderWidgetHostImpl* RenderFrameHostImpl::GetRenderWidgetHost() { 766 RenderWidgetHostImpl* RenderFrameHostImpl::GetRenderWidgetHost() {
767 if (render_widget_host_)
768 return render_widget_host_.get();
769
770 // TODO(kenrb): When RenderViewHost no longer inherits RenderWidgetHost,
771 // we can remove this fallback. Currently it is only used for the main
772 // frame.
732 return static_cast<RenderWidgetHostImpl*>(render_view_host_); 773 return static_cast<RenderWidgetHostImpl*>(render_view_host_);
733 } 774 }
734 775
776 RenderWidgetHostView* RenderFrameHostImpl::GetView() {
777 RenderFrameHostImpl* frame = this;
778 while (frame) {
779 if (frame->render_widget_host_)
780 return frame->render_widget_host_->GetView();
781 frame = static_cast<RenderFrameHostImpl*>(frame->GetParent());
782 }
783
784 return render_view_host_->GetView();
785 }
786
735 int RenderFrameHostImpl::GetEnabledBindings() { 787 int RenderFrameHostImpl::GetEnabledBindings() {
736 return render_view_host_->GetEnabledBindings(); 788 return render_view_host_->GetEnabledBindings();
737 } 789 }
738 790
739 void RenderFrameHostImpl::OnCrossSiteResponse( 791 void RenderFrameHostImpl::OnCrossSiteResponse(
740 const GlobalRequestID& global_request_id, 792 const GlobalRequestID& global_request_id,
741 scoped_ptr<CrossSiteTransferringRequest> cross_site_transferring_request, 793 scoped_ptr<CrossSiteTransferringRequest> cross_site_transferring_request,
742 const std::vector<GURL>& transfer_url_chain, 794 const std::vector<GURL>& transfer_url_chain,
743 const Referrer& referrer, 795 const Referrer& referrer,
744 ui::PageTransition page_transition, 796 ui::PageTransition page_transition,
(...skipping 860 matching lines...) Expand 10 before | Expand all | Expand 10 after
1605 void RenderFrameHostImpl::DidUseGeolocationPermission() { 1657 void RenderFrameHostImpl::DidUseGeolocationPermission() {
1606 RenderFrameHost* top_frame = frame_tree_node()->frame_tree()->GetMainFrame(); 1658 RenderFrameHost* top_frame = frame_tree_node()->frame_tree()->GetMainFrame();
1607 GetContentClient()->browser()->RegisterPermissionUsage( 1659 GetContentClient()->browser()->RegisterPermissionUsage(
1608 PERMISSION_GEOLOCATION, 1660 PERMISSION_GEOLOCATION,
1609 delegate_->GetAsWebContents(), 1661 delegate_->GetAsWebContents(),
1610 GetLastCommittedURL().GetOrigin(), 1662 GetLastCommittedURL().GetOrigin(),
1611 top_frame->GetLastCommittedURL().GetOrigin()); 1663 top_frame->GetLastCommittedURL().GetOrigin());
1612 } 1664 }
1613 1665
1614 } // namespace content 1666 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698