Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 616113002: Rename keyNeeded() to encrypted() in Chromium. (Closed)

Created:
6 years, 2 months ago by sandersd (OOO until July 31)
Modified:
6 years, 2 months ago
Reviewers:
jrummell, ddorwin
CC:
chromium-reviews, eme-reviews_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename keyNeeded() to encrypted() in Chromium. BUG=224786 Committed: https://crrev.com/efbe2dfcf88daa9e92d636bdfe35f9dc3e1a8661 Cr-Commit-Position: refs/heads/master@{#299986}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/crypto/encrypted_media_player_support_impl.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 9 (3 generated)
sandersd (OOO until July 31)
6 years, 2 months ago (2014-10-14 18:05:29 UTC) #2
jrummell
lgtm
6 years, 2 months ago (2014-10-14 18:43:54 UTC) #3
ddorwin
LGTM for the API change. Comments for potential internal changes later. https://codereview.chromium.org/616113002/diff/1/content/renderer/media/crypto/encrypted_media_player_support_impl.cc File content/renderer/media/crypto/encrypted_media_player_support_impl.cc (right): ...
6 years, 2 months ago (2014-10-14 18:54:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616113002/1
6 years, 2 months ago (2014-10-16 20:26:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 22:03:04 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 22:03:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efbe2dfcf88daa9e92d636bdfe35f9dc3e1a8661
Cr-Commit-Position: refs/heads/master@{#299986}

Powered by Google App Engine
This is Rietveld 408576698