Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 616093002: GN, GYP: Remove -Wno-incompatible-pointer-types flag for building NSS. (Closed)

Created:
6 years, 2 months ago by engedy
Modified:
6 years, 2 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GN, GYP: Remove -Wno-incompatible-pointer-types flag for building NSS. This workaround is no longer needed as the NSS bug was fixed in NSS 3.12.10 (see: https://bugzilla.mozilla.org/show_bug.cgi?id=635778), and Chromium requires NSS 3.14.3 or later now. BUG=138571 Committed: https://crrev.com/0b29bcaaf9afc46785a7b757fd4292fa07dfcef0 Cr-Commit-Position: refs/heads/master@{#297809}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M net/third_party/nss/ssl.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M net/third_party/nss/ssl/BUILD.gn View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
engedy
Wan-Teh: PTAL, this is a follow-up to https://codereview.chromium.org/582403002/. Note that this CL is already based ...
6 years, 2 months ago (2014-09-30 18:24:36 UTC) #2
wtc
Patch set 3 LGTM. Thanks!
6 years, 2 months ago (2014-10-02 00:38:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616093002/60001
6 years, 2 months ago (2014-10-02 11:11:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:60001) as 04e192c8e7468c66470dc9202b3082b2ac5f2d4f
6 years, 2 months ago (2014-10-02 11:55:25 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 11:56:18 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0b29bcaaf9afc46785a7b757fd4292fa07dfcef0
Cr-Commit-Position: refs/heads/master@{#297809}

Powered by Google App Engine
This is Rietveld 408576698