Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 616063004: Add --output-dir flag for page_runner.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use more generic --output-dir Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_runner.py
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py
index fa5c347cfffc56a19c375ae1cdf5c0f1c1b3bd95..11a532b9d8779ad9afe45e76ade938e9fef87a2c 100644
--- a/tools/telemetry/telemetry/page/page_runner.py
+++ b/tools/telemetry/telemetry/page/page_runner.py
@@ -124,7 +124,10 @@ class _RunState(object):
def StartProfiling(self, page, finder_options):
if not self.profiler_dir:
- self.profiler_dir = tempfile.mkdtemp()
+ if finder_options.output_dir:
+ self.profiler_dir = finder_options.output_dir
+ else:
nednguyen 2014/10/01 04:37:36 This is awkward since results.html will no longer
ariblue 2014/10/01 17:21:09 I just wanted to keep the default behavior the sam
+ self.profiler_dir = tempfile.mkdtemp()
output_file = os.path.join(self.profiler_dir, page.file_safe_name)
is_repeating = (finder_options.page_repeat != 1 or
finder_options.pageset_repeat != 1)
@@ -219,6 +222,7 @@ def AddCommandLineArgs(parser):
def ProcessCommandLineArgs(parser, args):
page_filter.PageFilter.ProcessCommandLineArgs(parser, args)
+ results_options.ProcessCommandLineArgs(parser, args)
# Page set options
if args.pageset_shuffle_order_file and not args.pageset_shuffle:

Powered by Google App Engine
This is Rietveld 408576698