Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 616043003: mojo::RawChannelWin: Use GetOverlappedResult() to retrive read bytes. (Closed)

Created:
6 years, 2 months ago by Hajime Morrita
Modified:
6 years, 2 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo::RawChannelWin: Use GetOverlappedResult() to retrive read bytes. The MSDN document suggests that with overlapped I/O, |lpNumberOfBytesRead| parameter of ReadFile() API isn't reliable and shouldn't be used. GetOverlappedResult() should be used instead, according to the doc. See: http://msdn.microsoft.com/en-us/library/windows/desktop/aa365467(v=vs.85).aspx This is a speculative crash fix for crbug.com/41509. The crash happens only on Windows. The report also implies that there might be some message duplication.It is possible if the value of |lpNumberOfBytesRead| is wrong. BUG=415059 R=viettrungluu@chromium.org Committed: https://crrev.com/f7ef6dd233c8c0b7d237e35476c44b2c26d2bab0 Cr-Commit-Position: refs/heads/master@{#297500}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M mojo/system/raw_channel_win.cc View 1 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Hajime Morrita
6 years, 2 months ago (2014-09-30 18:04:53 UTC) #1
Hajime Morrita
Yuzhu pointed that the MSDN link was wrong. Fixed.
6 years, 2 months ago (2014-09-30 18:13:39 UTC) #2
viettrungluu
lgtm w/nit https://codereview.chromium.org/616043003/diff/1/mojo/system/raw_channel_win.cc File mojo/system/raw_channel_win.cc (right): https://codereview.chromium.org/616043003/diff/1/mojo/system/raw_channel_win.cc#newcode377 mojo/system/raw_channel_win.cc:377: NULL, nullptr
6 years, 2 months ago (2014-09-30 19:07:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616043003/20001
6 years, 2 months ago (2014-09-30 19:34:41 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b2558938ed65332ec1caf36d81bcdcdd7ae90913
6 years, 2 months ago (2014-09-30 21:25:08 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 21:25:50 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f7ef6dd233c8c0b7d237e35476c44b2c26d2bab0
Cr-Commit-Position: refs/heads/master@{#297500}

Powered by Google App Engine
This is Rietveld 408576698