Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Issue 616033002: Clean up SK_PICTURE_USE_SK_RECORD and SK_PICTURE_OPTIMIZE_SK_RECORD. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Clean up SK_PICTURE_USE_SK_RECORD and SK_PICTURE_OPTIMIZE_SK_RECORD. This folds the code through as if they were defined, which is the explicit state in both our build and Chrome's. This leaves the EXPERIMENTAL_ and DEPRECATED_ hooks in to be cleaned up or privatized later. CQ_EXTRA_TRYBOTS=tryserver.skia:Canary-Chrome-Ubuntu13.10-Ninja-x86_64-ToT-Trybot BUG=skia: Committed: https://skia.googlesource.com/skia/+/8de02f4bf3dfb6178132231d03caec9f9a5d0beb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkPictureRecorder.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein
API changes: removal of two compile-time flags and an updated comment. This CL commits us ...
6 years, 2 months ago (2014-09-30 17:47:15 UTC) #2
robertphillips
lgtm
6 years, 2 months ago (2014-09-30 17:49:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616033002/1
6 years, 2 months ago (2014-09-30 17:55:02 UTC) #5
reed1
lgtm
6 years, 2 months ago (2014-09-30 18:21:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616033002/1
6 years, 2 months ago (2014-09-30 18:22:07 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 18:43:59 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 8de02f4bf3dfb6178132231d03caec9f9a5d0beb

Powered by Google App Engine
This is Rietveld 408576698