Issue 61603008: Remove mutex around image decoding in skpdiff.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 61603008: Remove mutex around image decoding in skpdiff. (Closed)

Created:
7 years, 1 month ago by scroggo

Modified:
7 years, 1 month ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Remove mutex around image decoding in skpdiff. I removed the mutex to investigate BUG=skia:1803 , and I get no crashes. The crashes may have been related to other multithreading issues. Removing the mutex will allow skpdiff to run faster. Committed: http://code.google.com/p/skia/source/detail?r=12339

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -8 lines)			Patch
	M	tools/skpdiff/SkDiffContext.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
	M	tools/skpdiff/SkDiffContext.cpp	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scroggo

Derek, can you see if you're still able to reproduce? I can no longer get ...

7 years, 1 month ago (2013-11-18 16:32:10 UTC) #1

djsollen

On 2013/11/18 16:32:10, scroggo wrote: > Derek, can you see if you're still able to ...

7 years, 1 month ago (2013-11-21 13:45:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/61603008/1

7 years, 1 month ago (2013-11-21 14:29:52 UTC) #3

Message was sent while issue was closed.

Change committed as 12339

Expand Messages | Collapse Messages