Remove MediaSourcePrivate/SourceBufferPrivate

Source/core/html/TimeRangesTest.cpp

 /*
  * Copyright (c) 2013, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 43 matching lines @@
 TEST(TimeRanges, Empty)
 {
     ASSERT_RANGE("{ }", TimeRanges::create());
 }
 
 TEST(TimeRanges, SingleRange)
 {
     ASSERT_RANGE("{ [1,2) }", TimeRanges::create(1, 2));
 }
 
+TEST(TimeRanges, CreateFromWebTimeRanges)
+{
+    blink::WebTimeRanges webRanges(static_cast<size_t>(2));

[acolwell GONE FROM CHROMIUM, 2013/11/12 18:25:17]

nit: s/static_cast<size_t>(2)/2u/ ?

[philipj_slow, 2013/11/12 19:47:58]

Unfortunately, GCC then doesn't pick the correct constructor:

In file included from
../../third_party/WebKit/public/platform/WebTimeRange.h:34:0,
                 from ../../third_party/WebKit/Source/core/html/TimeRanges.h:30,
                 from
../../third_party/WebKit/Source/core/html/TimeRangesTest.cpp:32:
../../third_party/WebKit/public/platform/WebVector.h: In instantiation of
'blink::WebVector<T>::WebVector(const C&) [with C = unsigned int; T =
blink::WebTimeRange]':
../../third_party/WebKit/Source/core/html/TimeRangesTest.cpp:66:38:   required
from here
../../third_party/WebKit/public/platform/WebVector.h:90:9: error: subscripted
value is neither array nor pointer
../../third_party/WebKit/public/platform/WebVector.h:90:9: error: request for
member 'size' in 'other', which is of non-class type 'const unsigned int'
../../third_party/WebKit/public/platform/WebVector.h:90:9: error: request for
member 'size' in 'other', which is of non-class type 'const unsigned int'

+    webRanges[0].start = 0;
+    webRanges[0].end = 1;
+    webRanges[1].start = 2;
+    webRanges[1].end = 3;
+    ASSERT_RANGE("{ [0,1) [2,3) }", TimeRanges::create(webRanges));
+}
+
 TEST(TimeRanges, AddOrder)
 {
     RefPtr<TimeRanges> rangeA = TimeRanges::create();
     RefPtr<TimeRanges> rangeB = TimeRanges::create();
 
     rangeA->add(0, 2);
     rangeA->add(3, 4);
     rangeA->add(5, 100);
 
     std::string expected = "{ [0,2) [3,4) [5,100) }";
@@ skipping 207 matching lines @@
     rangesB->add(6, 9);
 
     ASSERT_RANGE("{ [0,2) [4,7) [8,10) }", rangesA);
     ASSERT_RANGE("{ [1,5) [6,9) }", rangesB);
 
     rangesA->intersectWith(rangesB.get());
 
     ASSERT_RANGE("{ [1,2) [4,5) [6,7) [8,9) }", rangesA);
     ASSERT_RANGE("{ [1,5) [6,9) }", rangesB);
 }