Remove MediaSourcePrivate/SourceBufferPrivate

public/platform/WebMimeRegistry.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WebMimeRegistry_h
 #define WebMimeRegistry_h
 
 #include "WebCommon.h"
+#include "WebString.h"

[acolwell GONE FROM CHROMIUM, 2013/11/11 18:06:55]

Why is this include needed now?

[philipj_slow, 2013/11/12 09:43:51]

The forward declaration is weird, because the concrete blink::WebString type is
used, not just pointers or references. I got into a situation when because I had
removed some header included before WebMimeRegistry.h, WebString.h was no longer
included first and it didn't compile. However, now it works with this reverted,
so presumably I moved headers more after the fix to make this change
unnecessary. Reverting.

 
 namespace blink {
-class WebString;
 
 class WebMimeRegistry {
 public:
     enum SupportsType { IsNotSupported, IsSupported, MayBeSupported };
 
     virtual SupportsType supportsMIMEType(const blink::WebString& mimeType) = 0;
     virtual SupportsType supportsImageMIMEType(const blink::WebString& mimeType) = 0;
     virtual SupportsType supportsJavaScriptMIMEType(const blink::WebString& mimeType) = 0;
     virtual SupportsType supportsMediaMIMEType(const blink::WebString& mimeType, const blink::WebString& codecs, const blink::WebString& keySystem) = 0;
 
     virtual bool supportsMediaSourceMIMEType(const blink::WebString& mimeType, const blink::WebString& codecs) = 0;
 
     virtual SupportsType supportsNonImageMIMEType(const blink::WebString& mimeType) = 0;
 
     virtual blink::WebString mimeTypeForExtension(const blink::WebString& fileExtension) = 0;
     virtual blink::WebString wellKnownMimeTypeForExtension(const blink::WebString& fileExtension) = 0;
     virtual blink::WebString mimeTypeFromFile(const blink::WebString& filePath) = 0;
 
 protected:
     ~WebMimeRegistry() { }
 };
 
 } // namespace blink
 
 #endif