Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 616023002: Allow previously-hoisted layers to be reused in the same draw (Closed)

Created:
6 years, 2 months ago by robertphillips
Modified:
6 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Allow previously-hoisted layers to be reused in the same draw In the Sierpinkski test case there are only a few layers appear in the "to be drawn" lists but they those layers get reused a lot of times with different transforms. This CL adds an additional category to allow such layers to be placed in the GrReplacements object without needing to be rendered. This is split out of (Fix sub-picture layer rendering bugs - https://codereview.chromium.org/597293002/) BUG=skia:2315 Committed: https://skia.googlesource.com/skia/+/b5a97154f893a5fd3495e16872d370124e93c6ca

Patch Set 1 #

Patch Set 2 : Add comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -16 lines) Patch
M src/gpu/GrLayerHoister.h View 1 2 chunks +9 lines, -2 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 6 chunks +18 lines, -8 lines 0 comments Download
M src/gpu/GrPictureUtils.cpp View 1 chunk +2 lines, -2 lines 1 comment Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
robertphillips
https://codereview.chromium.org/616023002/diff/20001/src/gpu/GrPictureUtils.cpp File src/gpu/GrPictureUtils.cpp (right): https://codereview.chromium.org/616023002/diff/20001/src/gpu/GrPictureUtils.cpp#newcode129 src/gpu/GrPictureUtils.cpp:129: dst.fOffset = SkIPoint::Make(newClip.fLeft, newClip.fTop); This is just a minor ...
6 years, 2 months ago (2014-09-30 17:44:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/616023002/20001
6 years, 2 months ago (2014-09-30 17:48:05 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-09-30 17:48:05 UTC) #5
bsalomon
lgtm
6 years, 2 months ago (2014-09-30 18:32:28 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 18:33:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as b5a97154f893a5fd3495e16872d370124e93c6ca

Powered by Google App Engine
This is Rietveld 408576698