Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 615993003: optimize setRectFan and join -- from profiling drawText (Closed)

Created:
6 years, 2 months ago by reed2
Modified:
6 years, 2 months ago
Reviewers:
jvanverth1, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

optimize setRectFan and join -- from profiling drawText BUG=skia: NOTREECHECKS=True NOTRY=True Committed: https://skia.googlesource.com/skia/+/d9c42f71c391baa23c5ed5934444077e96a68638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M include/core/SkPoint.h View 1 chunk +10 lines, -1 line 0 comments Download
M src/core/SkPoint.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M src/core/SkRect.cpp View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
reed2
6 years, 2 months ago (2014-10-01 02:06:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615993003/1
6 years, 2 months ago (2014-10-01 02:07:10 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-01 02:07:11 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 2 months ago (2014-10-01 08:07:13 UTC) #7
reed1
lgtm
6 years, 2 months ago (2014-10-01 12:44:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615993003/1
6 years, 2 months ago (2014-10-01 12:45:34 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile ()
6 years, 2 months ago (2014-10-01 12:47:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615993003/1
6 years, 2 months ago (2014-10-01 14:21:17 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 14:21:27 UTC) #18
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as d9c42f71c391baa23c5ed5934444077e96a68638

Powered by Google App Engine
This is Rietveld 408576698