Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 615953005: Move page scale animation from LayerTreeHostImpl to LayerTreeImpl (Closed)

Created:
6 years, 2 months ago by bokan
Modified:
6 years, 2 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, jdduke+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move page scale animation from LayerTreeHostImpl to LayerTreeImpl When a text field is focused on Android, the keyboard comes up and the field is zoomed into the viewport. The page scale animation that is created would happen in LayerTreeHostImpl, however, the resized viewport layers were still in the sync_tree until it got activated. This led to incorrect clamping of the viewport when the text field was near the bottom of the document and becomes more visible when virtual viewport pinch to zoom is turned on. BUG=364217, 419450 Committed: https://crrev.com/915bf3594a53100adf71c2546aee0eaf63958291 Cr-Commit-Position: refs/heads/master@{#297913}

Patch Set 1 #

Patch Set 2 : Formatting nits #

Patch Set 3 : Rebase #

Patch Set 4 : Unittest build fix #

Patch Set 5 : Added CC_EXPORT to PageScaleAnimation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -61 lines) Patch
M cc/input/input_handler.h View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/input/page_scale_animation.h View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 2 chunks +7 lines, -42 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 3 5 chunks +100 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 3 chunks +44 lines, -0 lines 0 comments Download
M content/renderer/input/input_handler_proxy_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
bokan
PTAL
6 years, 2 months ago (2014-10-01 21:02:49 UTC) #2
bokan
On 2014/10/01 21:02:49, bokan wrote: > PTAL Also note this fixes the issue in the ...
6 years, 2 months ago (2014-10-01 21:10:19 UTC) #3
aelias_OOO_until_Jul13
lgtm
6 years, 2 months ago (2014-10-02 00:41:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615953005/20001
6 years, 2 months ago (2014-10-02 12:29:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/20484) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/15248) win8_chromium_rel ...
6 years, 2 months ago (2014-10-02 12:33:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615953005/40001
6 years, 2 months ago (2014-10-02 13:51:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/21030) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/21127)
6 years, 2 months ago (2014-10-02 13:58:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615953005/60001
6 years, 2 months ago (2014-10-02 14:10:51 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/4417)
6 years, 2 months ago (2014-10-02 14:27:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615953005/80001
6 years, 2 months ago (2014-10-02 18:42:31 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 675eefcb8ced04a1ad2349296058268abd29535f
6 years, 2 months ago (2014-10-02 21:57:26 UTC) #19
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 21:58:16 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/915bf3594a53100adf71c2546aee0eaf63958291
Cr-Commit-Position: refs/heads/master@{#297913}

Powered by Google App Engine
This is Rietveld 408576698