Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 615953002: cc: Leave using_image capability as false when using software. (Closed)

Created:
6 years, 2 months ago by reveman
Modified:
6 years, 2 months ago
Reviewers:
danakj, piman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@map-image-rename
Project:
chromium
Visibility:
Public.

Description

cc: Leave using_image capability as false when using software. The value of this currently doesn't matter when using software. BUG=418553 R=piman@chromium.org Committed: https://crrev.com/c1e6e106f35db2ece6bacb6922f9271b47cdcf02 Cr-Commit-Position: refs/heads/master@{#297434}

Patch Set 1 #

Total comments: 1

Patch Set 2 : don't set using_image #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M cc/output/delegating_renderer.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (4 generated)
reveman
6 years, 2 months ago (2014-09-30 12:33:34 UTC) #1
danakj
https://codereview.chromium.org/615953002/diff/1/cc/output/delegating_renderer.cc File cc/output/delegating_renderer.cc (right): https://codereview.chromium.org/615953002/diff/1/cc/output/delegating_renderer.cc#newcode48 cc/output/delegating_renderer.cc:48: capabilities_.using_image = false; or just leave it as the ...
6 years, 2 months ago (2014-09-30 14:02:16 UTC) #3
danakj
https://codereview.chromium.org/195733010 claims this is set true to avoid a copy, can you comment on that?
6 years, 2 months ago (2014-09-30 14:04:42 UTC) #4
reveman
On 2014/09/30 14:04:42, danakj wrote: > https://codereview.chromium.org/195733010 claims this is set true to avoid a ...
6 years, 2 months ago (2014-09-30 14:44:10 UTC) #5
danakj
Ok thanks. Just remove it instead of = false, and LGTM
6 years, 2 months ago (2014-09-30 15:19:59 UTC) #6
reveman
On 2014/09/30 15:19:59, danakj wrote: > Ok thanks. Just remove it instead of = false, ...
6 years, 2 months ago (2014-09-30 15:26:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615953002/20001
6 years, 2 months ago (2014-09-30 15:27:16 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/62513) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/15072)
6 years, 2 months ago (2014-09-30 15:30:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615953002/20001
6 years, 2 months ago (2014-09-30 15:42:25 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 87472144c3db05f05a04a0f4d3c0b5b797de548f
6 years, 2 months ago (2014-09-30 16:34:33 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 16:35:05 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c1e6e106f35db2ece6bacb6922f9271b47cdcf02
Cr-Commit-Position: refs/heads/master@{#297434}

Powered by Google App Engine
This is Rietveld 408576698