Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 615933003: Remove sweeper threads (Closed)

Created:
6 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove sweeper threads Job based sweeping is enabled since 3.29, so remove the now obsolete thread based implementation BUG=none R=hpayer@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=24352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -216 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 5 chunks +19 lines, -45 lines 0 comments Download
D src/heap/sweeper-thread.h View 1 chunk +0 lines, -45 lines 0 comments Download
D src/heap/sweeper-thread.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M src/isolate.h View 2 chunks +0 lines, -10 lines 0 comments Download
M src/isolate.cc View 5 chunks +1 line, -26 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-09-30 12:20:32 UTC) #1
jochen (gone - plz use gerrit)
ptal I'll remove the parallel sweeping in a follow-up cl
6 years, 2 months ago (2014-09-30 12:20:49 UTC) #2
Hannes Payer (out of office)
lgtm
6 years, 2 months ago (2014-10-01 08:44:36 UTC) #3
jochen (gone - plz use gerrit)
6 years, 2 months ago (2014-10-01 09:16:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24352 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698