Issue 61593008: Magic fix for Math.sin/cos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 61593008: Magic fix for Math.sin/cos. (Closed)

Created:
7 years, 1 month ago by Yang

Modified:
7 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Magic fix for Math.sin/cos. It turns out that Sunspider 1.0's 3d-morph verifies that the floating point error must start with 6. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17725

Patch Set 1 #

Total comments: 1

Patch Set 2 : updated comments #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/math.js	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comment. https://codereview.chromium.org/61593008/diff/1/src/math.js File src/math.js (right): https://codereview.chromium.org/61593008/diff/1/src/math.js#newcode220 src/math.js:220: var samples = 4489; // Table ...

7 years, 1 month ago (2013-11-14 09:56:07 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r17725.

Expand Messages | Collapse Messages