Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: webkit/browser/fileapi/quota/quota_reservation_manager_unittest.cc

Issue 61593002: Quota: Implement QuotaBackendImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix build and test Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/browser/fileapi/quota/quota_reservation_manager_unittest.cc
diff --git a/webkit/browser/fileapi/quota/quota_reservation_manager_unittest.cc b/webkit/browser/fileapi/quota/quota_reservation_manager_unittest.cc
index 86590c7a69a85667a60ae775cd6274d18506f156..d7c00458d53e65e0f6033dc4148c56eb9616d03c 100644
--- a/webkit/browser/fileapi/quota/quota_reservation_manager_unittest.cc
+++ b/webkit/browser/fileapi/quota/quota_reservation_manager_unittest.cc
@@ -64,10 +64,10 @@ class FakeBackend : public QuotaReservationManager::QuotaBackend {
FROM_HERE, base::Bind(callback, base::PLATFORM_FILE_OK));
}
- virtual void IncreaseDirtyCount(const GURL& origin,
- FileSystemType type) OVERRIDE {}
- virtual void DecreaseDirtyCount(const GURL& origin,
- FileSystemType type) OVERRIDE {}
+ virtual void IncrementDirtyCount(const GURL& origin,
+ FileSystemType type) OVERRIDE {}
+ virtual void DecrementDirtyCount(const GURL& origin,
+ FileSystemType type) OVERRIDE {}
int64 on_memory_usage() { return on_memory_usage_; }
int64 on_disk_usage() { return on_disk_usage_; }
@@ -106,14 +106,12 @@ class QuotaReservationManagerTest : public testing::Test {
file_path_ = work_dir_.path().Append(FILE_PATH_LITERAL("hoge"));
SetFileSize(kInitialFileSize);
- fake_backend_.reset(new FakeBackend);
- reservation_manager_.reset(new QuotaReservationManager(
- fake_backend_.get()));
+ fake_backend_ = new FakeBackend;
+ reservation_manager_.reset(new QuotaReservationManager(fake_backend_));
}
virtual void TearDown() OVERRIDE {
reservation_manager_.reset();
- fake_backend_.reset();
}
int64 GetFileSize() {
@@ -140,7 +138,7 @@ class QuotaReservationManagerTest : public testing::Test {
}
FakeBackend* fake_backend() {
- return fake_backend_.get();
+ return fake_backend_;
}
QuotaReservationManager* reservation_manager() {
@@ -155,9 +153,11 @@ class QuotaReservationManagerTest : public testing::Test {
base::MessageLoop message_loop_;
base::ScopedTempDir work_dir_;
base::FilePath file_path_;
- scoped_ptr<FakeBackend> fake_backend_;
scoped_ptr<QuotaReservationManager> reservation_manager_;
+ // Owned by QuotaReservationManager.
+ FakeBackend* fake_backend_;
+
DISALLOW_COPY_AND_ASSIGN(QuotaReservationManagerTest);
};

Powered by Google App Engine
This is Rietveld 408576698