util/file/string_file_writer_test.cc - Issue 615923004: Convert COMPILE_ASSERT to static_assert

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/file/string_file_writer_test.cc

Issue 615923004: Convert COMPILE_ASSERT to static_assert (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: fixes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: util/file/string_file_writer_test.cc

diff --git a/util/file/string_file_writer_test.cc b/util/file/string_file_writer_test.cc

index f0ec72f75e958da164887f85767abcaef9f82d7d..b55c778e90e9ecbfc1e71b708791343aa18ccdad 100644

--- a/util/file/string_file_writer_test.cc

+++ b/util/file/string_file_writer_test.cc

@@ -354,8 +354,8 @@ TEST(StringFileWriter, SeekInvalid) {

EXPECT_EQ(1, writer.Seek(0, SEEK_CUR));

EXPECT_TRUE(writer.string().empty());

- COMPILE_ASSERT(SEEK_SET != 3 && SEEK_CUR != 3 && SEEK_END != 3,

- three_must_be_invalid_for_whence);

+ static_assert(SEEK_SET != 3 && SEEK_CUR != 3 && SEEK_END != 3,

+ "3 must be invalid for whence");

EXPECT_LT(writer.Seek(0, 3), 0);

writer.Reset();

« no previous file with comments | « util/file/file_writer.cc ('k') | util/mac/mach_o_image_reader.cc » ('j') | no next file with comments »